bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.34k stars 1.26k forks source link

[PM-14551] Update copy for revoke dialog #12089

Open BTreston opened 23 hours ago

BTreston commented 23 hours ago

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-14551 https://bitwarden.atlassian.net/browse/PM-14552

๐Ÿ“” Objective

This PR updates the copy in the bulk revoke and restore dialogs. Since these both modify the same code, both changes will be made and tested at the same time.

๐Ÿ“ธ Screenshots

https://github.com/user-attachments/assets/b7bac24d-732c-4c88-a732-3988b2ee6e8d

https://github.com/user-attachments/assets/a090c40a-5d81-4feb-af85-e941abddc78f

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 23 hours ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.40%. Comparing base (4b6f70a) to head (9821b34).

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/components/bulk/bulk-restore-revoke.component.ts 0.00% 18 Missing :warning:
...console/organizations/members/members.component.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12089 +/- ## ========================================== - Coverage 33.41% 33.40% -0.01% ========================================== Files 2871 2871 Lines 89827 89844 +17 Branches 17105 17113 +8 ========================================== Hits 30012 30012 - Misses 57453 57470 +17 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

github-actions[bot] commented 11 minutes ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 3f7aafe0-e9bc-4551-af12-dcc2b33e2f10

No New Or Fixed Issues Found