bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

[CL-511] - add variant to links within banners #12090

Open jaasen-livefront opened 4 days ago

jaasen-livefront commented 4 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-511

📔 Objective

This PR updates link linkType prop from contrast to secondary for all components whose banners include a link, fixing a poor color contrast.

📸 Screenshots

Screenshot 2024-11-21 at 1 07 11 PM

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.44%. Comparing base (a9f570b) to head (3ff6b54). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12090 +/- ## ======================================= Coverage 33.44% 33.44% ======================================= Files 2865 2865 Lines 89650 89650 Branches 17070 17070 ======================================= Hits 29986 29986 Misses 57302 57302 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: