Auth/PM-15155 - 2FA Component Renames

JaredSnider-Bitwarden commented 4 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15155

📔 Objective

To refactor the names of our 2FA setup components to clarify the difference between the 2FA method setup components and the 2FA method implementation components. See commits for step by step naming conversion.

📸 Screenshots

n/a

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (9e9f977) to head (cc64969). Report is 8 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../settings/two-factor/two-factor-setup.component.ts	50.00%	5 Missing :warning:
...ganizations/settings/two-factor-setup.component.ts	0.00%	4 Missing :warning:
.../auth/settings/security/security-routing.module.ts	0.00%	1 Missing :warning:
...factor/two-factor-setup-authenticator.component.ts	66.66%	1 Missing :warning:
...tings/two-factor/two-factor-setup-duo.component.ts	66.66%	1 Missing :warning:
...ngs/two-factor/two-factor-setup-email.component.ts	66.66%	1 Missing :warning:
.../two-factor/two-factor-setup-webauthn.component.ts	66.66%	1 Missing :warning:
...s/two-factor/two-factor-setup-yubikey.component.ts	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12092 +/- ## ======================================= Coverage 33.42% 33.42% ======================================= Files 2871 2871 Lines 89811 89811 Branches 17103 17103 ======================================= + Hits 30016 30023 +7 + Misses 57433 57426 -7 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

JS Bundle Analysis - Avoid shipping oversized bundles

github-actions[bot] commented 4 days ago

Checkmarx One – Scan Summary & Details – 7e59a9c7-9579-474e-bf52-965cdf301139

bitwarden / clients