[PM-14593] Bugfix for "Cannot disable biometrics on extension" (ExtensionRefresh)

[rr-bw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14593

📔 Objective

In the legacy AccountSercurityV1Component the updateBiometric(enabled: boolean) method had an else block to handle an enabled value of false. The new AccountSecurityComponent is missing this block, which makes it so the user cannot disable biometrics because we aren't handling the case where they uncheck the biometrics checkbox. This PR just adds it back in so we handle a false value.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – 0d59feac-0f93-451d-aca4-57e2719e0b46

Fixed Issues

Severity	Issue	Source File / Package
	Client_DOM_XSS	/apps/web/src/connectors/redirect.ts: 15
	Client_DOM_XSS	/apps/web/src/connectors/redirect.ts: 6
	Absolute_Path_Traversal	/apps/cli/src/oss-serve-configurator.ts: 287
	Absolute_Path_Traversal	/apps/cli/src/oss-serve-configurator.ts: 319
	Absolute_Path_Traversal	/apps/cli/src/oss-serve-configurator.ts: 287
	Absolute_Path_Traversal	/apps/cli/src/oss-serve-configurator.ts: 319
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html: 1
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/layouts/product-switcher/product-switcher.component.html: 1
	Angular_Improper_Type_Pipe_Usage	/libs/components/src/navigation/nav-divider.component.html: 1
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/autofill/popup/fido2/fido2-use-browser-link.component.html: 1
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 55
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 45
	Client_Privacy_Violation	/libs/tools/generator/components/src/credential-generator-history.component.html: 3
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 502
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 514
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 657
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 670
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 564
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 580
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 684
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 496
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 557
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 653
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 209
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 656
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 647
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 646
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 645
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 644
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 643
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 710
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 409
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 2873
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 136
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 1644
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 2768
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 368
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 222
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 548
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 1719
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 453
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 436
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 413
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 1719
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 588
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 368
	Client_Privacy_Violation	/apps/browser/src/autofill/background/overlay.background.ts: 1718
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 484
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 457
	Client_Privacy_Violation

More results are available on AST platform

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (e6c68b7) to head (96cae79). Report is 8 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../auth/popup/settings/account-security.component.ts	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12099 +/- ## ========================================== - Coverage 33.42% 33.42% -0.01% ========================================== Files 2871 2871 Lines 89791 89816 +25 Branches 17098 17104 +6 ========================================== + Hits 30012 30019 +7 - Misses 57417 57435 +18 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• JS Bundle Analysis - Avoid shipping oversized bundles