bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.34k stars 1.26k forks source link

[PM-13667] Add button to open credential history on web #12100

Closed djsmith85 closed 1 hour ago

djsmith85 commented 7 hours ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13667

📔 Objective

Add button to the bottom of the credential-generator to open the credential generator history

📸 Screenshots

image

image

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 7 hours ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 33.41%. Comparing base (773bdd2) to head (2d9e728). Report is 4 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/app/app.component.ts 0.00% 7 Missing :warning:
.../tools/generator/credential-generator.component.ts 0.00% 6 Missing :warning:
...ential-generator/credential-generator.component.ts 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12100 +/- ## ========================================== - Coverage 33.41% 33.41% -0.01% ========================================== Files 2871 2871 Lines 89814 89827 +13 Branches 17104 17105 +1 ========================================== Hits 30012 30012 - Misses 57440 57453 +13 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 7 hours ago

Logo Checkmarx One – Scan Summary & Details4ee6ce4c-f6fe-47ad-ad2f-fc6d53c81130

No New Or Fixed Issues Found

djsmith85 commented 1 hour ago

Desktop changes made with https://github.com/bitwarden/clients/pull/12101 merged with 2d9e728 and have previously been reviewed