bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.36k stars 1.26k forks source link

[PM-14990] Add password prompt for ssh key import #12105

Open quexten opened 3 days ago

quexten commented 3 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14990

📔 Objective

Adds a password prompt UI for importing password protected ssh keys in the desktop app.

📸 Screenshots

https://github.com/user-attachments/assets/fa66e14d-5556-4a1b-b54f-6d4fbb9cf964

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 33.41%. Comparing base (38c4eeb) to head (2d85553). Report is 13 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/dialog/sshkey-password-prompt.component.ts 0.00% 15 Missing :warning:
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 10 Missing :warning:
libs/importer/src/components/dialog/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12105 +/- ## ========================================== - Coverage 33.44% 33.41% -0.03% ========================================== Files 2864 2872 +8 Lines 89637 89838 +201 Branches 17067 17107 +40 ========================================== + Hits 29978 30019 +41 - Misses 57297 57457 +160 Partials 2362 2362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: