bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.73k stars 1.14k forks source link

Autofill isn't working for a specific site #1621

Closed cscharf closed 4 months ago

cscharf commented 3 years ago

Describe the Bug

We are aware of many sites' login forms, payment gateways, identity forms, etc. where the Bitwarden browser extension either on a single platform/browser or multiple will not autofill information. This is something the Bitwarden team is actively working on but need your help as a community and active Bitwarden users!

Expected Result

When you have autofill configured and get to a page where you have saved credentials within Bitwarden, and your browser extension is unlocked, the credentials should be automatically populated. Otherwise, if you have saved information and use a manual action or command to autofill credentials, identity information, card information, etc.; it should properly populate the form.

Actual Result

This works most of the time, but not always and it can depend on many, many factors. Some sites simply don't work, some don't work consistently and others who knows. This is what we're aiming to fix!

Call to Action

Below is a link to a Google Form that we have created for capturing information that will help us track down all of these pages and forms where Bitwarden has failed to autofill your information. You may submit as many as you like, just please help us help you and the community by providing meaningful information and only those sites/pages where it legitimately doesn't work.

Report autofill failure Report autofill failure on Mobile

If you've been sent to this issue because another issue you had open was closed as a duplicate, thank you for taking the time to submit the issue to us, however we truly need to track this under a single item in aggregate fashion so we can manage it holistically and ensure we're taking broad measures that will improve this behavior with the maximum benefit to all. Please consider using the linked form above to submit the prior sites you had reported in the issue closed.

TheKidRock commented 1 year ago

Bitwarden Password autofill is not working on Chrome, Firefox, Edge in this bank's login page - https://itouch.nicasiabank.com/login.xhtml However, Firefox's default autofill is working but Chrome and Edge's default autofill is not working too. Tried with Keepass desktop and it also was able to fill the password.

SC-CTS commented 1 year ago

Can't login on AWS login forms like: https://signin.aws.amazon.com/oauth redirected from https://XXX.signin.aws.amazon.com/console

Worked fine last year and broke sometime in November/December.

Error in console when I select the login to autofill:

Error in event handler: TypeError: Cannot read properties of null (reading 'indexOf')
    at chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:618:40
    at Array.some (<anonymous>)
    at urlNotSecure (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:618:24)
    at doFill (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:636:28)
    at fill (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:1006:5)
    at chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:1029:7
djsmith85 commented 1 year ago

Can't login on AWS login forms like: https://signin.aws.amazon.com/oauth redirected from https://XXX.signin.aws.amazon.com/console

Worked fine last year and broke sometime in November/December.

Error in console when I select the login to autofill:

Error in event handler: TypeError: Cannot read properties of null (reading 'indexOf')
    at chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:618:40
    at Array.some (<anonymous>)
    at urlNotSecure (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:618:24)
    at doFill (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:636:28)
    at fill (chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:1006:5)
    at chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/content/autofill.js:1029:7

@SC-CTS It sounds like you might have URL entry on items matching those urls with null. Please have a look at this comment to a related issues, showing how to resolve it. (Re-creating the item(s) manually and then deleting the falsy one, would obviously also work.

In addition a null check was added with https://github.com/bitwarden/clients/pull/4277 and will be rolled out with the next release.

SC-CTS commented 1 year ago

@SC-CTS It sounds like you might have URL entry on items matching those urls with null. Please have a look at this comment to a related issues, showing how to resolve it. (Re-creating the item(s) manually and then deleting the falsy one, would obviously also work.

In addition a null check was added with #4277 and will be rolled out with the next release.

Ah wow, thanks. Somehow an empty URI got added to the item. Removed that now everything works again. Thanks a lot for the help!

abmclin commented 1 year ago

Opted to use Google Form instead

abmclin commented 1 year ago

Out of curiosity, would it be helpful to also list some sites where password update autodetection worked? In order to gauge how well detection techniques are working?

Greenderella commented 1 year ago

We appreciate everyone for letting us know about the pages you are having issues with. Due to the nature of autofill issues, we started to track them internally using different Forms depending on the platform:

In the future, if anyone encounters other pages or apps that do not autofill as expected, please avoid opening a new GitHub issue and go directly to the corresponding form.

Thanks!

eliykat commented 1 year ago

4119 has been merged, which fixes a limitation where autofill wasn't filling form elements located in shadow roots. That fix will be in the March release and should help with websites that use shadow roots.