search

bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.92k stars 1.16k forks source link

Vivaldi browser extension cannot download attachments unless popped out #1760

Open tangowithfoxtrot opened 3 years ago

tangowithfoxtrot commented 3 years ago

Describe the Bug

The browser extension will not download file attachments from entries unless it is opened in its own separate window. File attachments will temporarily display a "loading" animation, but never actually download the file.

Steps To Reproduce

  1. Open Vivaldi and click the Bitwarden extension.
  2. Locate an entry with a file attachment.
  3. Click the attachment to download the file.
  4. Loading animation displays, but nothing happens.

Expected Result

The file to download.

Actual Result

Nothing happens.

Environment

Additional Context

The only workaround for this that I've found is to open the extension in its own window. I also tried enabling "Save Files to Default Location Without Asking" in Vivaldi browser settings, but with no success.

Spitfireap commented 3 years ago

Same Issue here on vivaldi 3.7.2218.52 with Manjaro. Note that the extension do recieve a http 200 response upon clicking on downloading.

bitwarden-bot commented 2 years ago

Hi @tangowithfoxtrot, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

Midorina commented 1 year ago

I can confirm this is still an existing issue. Vivaldi version 5.6.2867.62 and Bitwarden version 2023.1.0.

ThisFungus commented 9 months ago

I confirm that the issue originally reported is still present in Vivaldi version 6.4.3160.42 and Bitwarden version 2023.10.2.

justindbaur commented 2 months ago

This looks to be a known bug and has a Vivaldi developer assigned to it. In Vivaldi per this comment on their forum: https://forum.vivaldi.net/post/748680

The forum post shows similar code to what we employ to download files: https://github.com/bitwarden/clients/blob/9322dacbd4d9309c52064d6da2ab9301de175cb5/apps/browser/src/platform/popup/services/browser-file-download.service.ts#L34-L39

Opening this as a tracking issue for the original bug in Vivaldi.

Internal Ticket: https://bitwarden.atlassian.net/browse/PM-862