bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.34k stars 1.26k forks source link

Keyboard Shortcut (SHIFT+CMD+L) fails intermittently #2475

Open brijazz opened 2 years ago

brijazz commented 2 years ago

Steps To Reproduce

The SHIFT+CMD+L keyboard has been failing over time since updating to Mac OS 12.3. Restarting Safari resolves the issue, but the shortcut will eventually stop working again. This has been confirmed by multiple users as discussed at https://community.bitwarden.com/t/keyboard-shortcut-shift-cmd-l-fails-intermittently/39515

Expected Result

Keyboard shortcut should fill credentials reliably

Actual Result

Keyboard shortcut does not fill credentials reliably

Screenshots or Videos

No response

Additional Context

No response

Operating System

macOS

Operating System Version

12.3

Web Browser

Safari

Browser Version

15.4 (17613.1.17.1.6)

Build Version

1.32.1

ritikBhandari commented 2 years ago

Is this issue coming with Apple devices only?

brijazz commented 2 years ago

For me, yes. Same for the other user who mentioned this issue. On Mar 27, 2022, 5:01 PM -0400, Ritik Bhandari @.***>, wrote:

Is this issue coming with Apple devices only? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

Crocmagnon commented 2 years ago

I'm also affected only on Safari. Works fine on Firefox on the same device.

When the shortcut doesn't work, I've also noticed that the badge indicating the number of entries doesn't appear even if clicking on the extension brings the menu and displays the proper login.

brijazz commented 2 years ago

What others have found is that the issue is reproducible on M1 Macs running MacOS 12.3. Is that your setup? On Mar 30, 2022, 1:07 PM -0400, Gabriel Augendre @.***>, wrote:

I'm also affected only on Safari. Works fine on Firefox on the same device. When the shortcut doesn't work, I've also noticed that the badge indicating the number of entries doesn't appear even if clicking on the extension brings the menu and displays the proper login. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

Crocmagnon commented 2 years ago

Yes indeed!

c4539 commented 2 years ago

I had the same issue – opening Bitwarden (App) from the AppStore once solved it ... it's weird though.

accolon commented 2 years ago

Since I almost never use the Bitwarden app I tried your suggestion @c4539. Afterwards, macOS asked for my credentials when I tried to unlock the Bitwarden extension in Safari with my fingerprint (which is curious by itself, I always thought app and extension were independent).

The original problem remains, though: Unlock Bitwarden extension with fingerprint after pressing Cmd+Shift+L, close the MacBook to enable standby, wait a minute, open it again. BW extension is locked, keyboard shortcut doesn't work anymore, badge is gone. Only restarting Safari or disabling/enabling the BW extension makes it work again.

alefchak commented 2 years ago

What others have found is that the issue is reproducible on M1 Macs running MacOS 12.3. Is that your setup?

Having the same issue on an Intel Mac, here (macOS 12.3.1).

Skymax1986 commented 2 years ago

actually since 12.3.1 or the latest safari update (Version 15.4) the issue seems to be resolved for me (macbook pro m1)

3zero2 commented 2 years ago

Still experiencing the issue on 12.3.1 using an M1 Mac.

alefchak commented 2 years ago

actually since 12.3.1 or the latest safari update (Version 15.4) the issue seems to be resolved for me (macbook pro m1)

It seemed to work for me once again for the past two days, but back to not working again. Very strange.

i814u2 commented 2 years ago

My setup (I skipped the template, in the interest of keeping this post a bit smaller. If that's bad, let me know): macOS 12.3.1 (M1 Pro) Safari 15.4 (17613.1.17.1.13) Extension 1.57.0 App 1.32.1 (2467)


Same for me. I uninstalled the macOS app, and Safari extension. I re-installed, everything was fine for a bit. Now it's failing to read the URI properly, again. Disable/enable the extension and it is locked, but CMD+SHIFT+L prompts for password.

From a bit of testing, it seems that this is somehow tied to using a fingerprint to authenticate. Similar to Accolon's post, but I don't seem to need to wait for it to fail, just refresh a page.

Here's what I tested: If I use fingerprint to authenticate, it shows a (1) badge for GitHub (as expected). I then refreshed the page (didn't use the extension at all), and it shows nothing. I repeated the disable/enable steps for the extension. Pressed CMD+SHIFT+L, entered password manually, clicked "Unlock", then clicked "Cancel" on the biometrics dialog box. This time, I'm able to repeatedly refresh and the badge still displays.

For now, the work-around seems to be to not use the "biometric" option for logging in to the extension. That's a bummer, but hopefully that info can point someone in the right direction to fix the issue.

crenwick commented 2 years ago

Came here to report the same issue.

From what I've seen over the past month or so, the keyboard shortcut does work when I'm logged out of the extension (or the extension is requiring my password). As soon as I enter my password into the extension, the shortcut stops working.

Firefox and Chrome don't seem to have this issue on my machine.

pkrakowiak commented 2 years ago

I observe the same behavior as described above.

Intel macOS 12.4 Safari 15.5 Bitwarden 1.58.0

ivankovnatsky commented 2 years ago

Isn't this because of Cmd+Shift+L shortcut being a Safari sidebar show/hide and Bitwarden's extension shortcut at the same time? And I'm thinking on my end why on earth sidebar on Safari stopped working.

I remember I had different glitches with Bitwarden on Safari, seems like not much changed.

pkrakowiak commented 2 years ago

Well, the shortcuts were always the same and it worked fine. It broke after some recent Safari / macOS updates.

mada199122 commented 2 years ago

Even with the shortcut for toggling the sidebar changed, the issue is still present...

wookiesh commented 2 years ago

version 2022.5.1 and I still have the issue on osx 12.4 with safari 15.5 (17613.2.7.1.8).

mada199122 commented 2 years ago

version 2022.5.1 and I still have the issue on osx 12.4 with safari 15.5 (17613.2.7.1.8).

I confirm the issue with that version.

jkmeansesc commented 2 years ago

same for me safari extension version: 2022.5.0 safari version: Version 15.5 (17613.2.7.1.8) m1 max: macOS Monterey 12.4 note: default cmd+shift+L shortcut for "Search With Google" is turned off.

say4n commented 2 years ago

+1 on this issue, M1 Pro SoC, with Safari (version 15.5 (17613.2.7.1.8)), Bitwarden (version 2022.5.0) and macOS 12.4.

dbosompem commented 2 years ago

Hi all, apologies for the inconveniences caused. I'd be sure to follow up with the team for a faster resolution.

NateFuller commented 2 years ago

Shift-CMD-L is Safari's default shortcut for showing hiding the side bar. Imo Bitwarden's shortcut should not override this by default, and there should be a way to customize Bitwarden's shortcuts.

This all said, I'm guessing the conflicting nature of these two shortcuts is probably likely to cause issues.

Albatrosicks commented 2 years ago

I fixed this by reassigning the Safari shortcuts like this:

Screenshot 2022-11-21 at 16 55 36

After applying the setting restart is required. And after the reboot, as I remember, I needed to set the setting again.

theodoresi commented 1 year ago

I fixed this by reassigning the Safari shortcuts like this: Screenshot 2022-11-21 at 16 55 36

After applying the setting restart is required. And after the reboot, as I remember, I needed to set the setting again.

This is really useful, thanks!

gdw2 commented 8 months ago

I'm having this issue on Mac OSX with Firefox. After FF has been open for a while, the shortcut doesn't work. If I change the shortcut, it works, but then days/weeks later, it will stop working. I'm not sure what the trigger is.

If I open a new FF window, it will work in the new window, but not the old one.

polarOpposites commented 2 months ago

Issue is present on MacBook Air with M3 chip. Other browsers are fine, only Safari having issue. I tried the shortcut reassignment for the view/hide sidebar as shared above. It worked once but only once.

My experience with this bug:

  1. Open Safari
  2. Unlock Bitwarden app
  3. Navigate to a login page
  4. Cursor defaults to username field (username field as focus)
  5. CMD + Shift + L
  6. Username field loses focus and no characters appear
  7. Click the Bitwarden extension icon and data populates to username and password field
beResonant commented 2 months ago

Come on guys. WTH?!?!?

tmpope commented 2 months ago

I had this at some point in the past and it wasn't an issue for quite a while, but now it's back. When I hit CMD + Shift + L nothing happens, but then when I click the icon for the extension the fields autofill, so it seems to be not allowing the app to trigger without being explicitly opened.

beResonant commented 2 months ago

@tmpope I never experienced this in the past, where everything was fine and then the behavior appeared, went away, and came back. I only noticed it as a thing within the last few months. My login behavior is changing with the emergence of passkeys, so it's hard to tell exactly when the problem started.

Prompted by your message, I just found a workaround that works for me every time:

  1. After page load, hit CMD+SHIFT+L (_as if trying to trigger autofill)
  2. Hit CMD+SHIFT+Y to activate the extension overlay popup menu. ---------- fields will be autofilled at this point ----------
  3. Hit CMD+SHIFT+Y again to hide the overlay.

For reference, I am on Apple Silicon (M1 Max), using MacOS Sonoma 14.6.1, with Safari 17.6. I also have "Show Sidebar" and "Hide Sidebar" in System Settings > Keyboard > Keyboard Shortcuts > App Shortcuts > Safari.app mapped to something other than CMD+SHIFT+L.

Like I said before, come on Bitwarden folks! This issue has apparently existed for two years?

bunnyhero commented 1 month ago

I don't know if this is a clue that could help narrow this down, but when I encounter this frustrating issue, if I then click on the Bitwarden extension button in the Safari toolbar, the fields suddenly autofill.

Senui commented 1 month ago

Is there any way to find the error logs that could help in solving this issue? Can someone from the dev team give any clues? I'd be willing to reproduce the error and post the logs.

beResonant commented 1 month ago

And now, with Safari 18.0 (still on Sonoma), and the latest Bitwarden extension (v 2024.8.1), the expected CMD+SHIFT+L is working without my workaround from a few days ago. I just updated today. What's up Bitwarden??

tmpope commented 1 month ago

It is also currently working for me

tmpope commented 1 month ago

Mine started failing again a day or two after my post with no apparent trigger