search

bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.28k stars 1.25k forks source link

remove space character from path for bw cli unix client #2740

Open tjyang opened 4 years ago

tjyang commented 4 years ago

Hi

Not a urgent issue. But please consider to remove space character from path for bw client on Unix. Example: "/.config/Bitwarden\ CLI"

bryankaplan commented 2 years ago

I second this request. It's unprofessional to put a space in a filename in any *nix fs.

Note, however, that we can specify the config dir with the BITWARDENCLI_APPDATA_DIR env var, as programmed here.

joshtrichards commented 1 year ago
  1. Switching to $HOME/.config/bw or even $HOME/.bw would probably be the most concise but... I fear clashes. Perhaps $HOME/[.config]/bitwarden instead would avoid that?
  2. Including backwards compatibility (i.e. looking for the old default path too) will remain an indefinite necessity. I dislike the spaces/escaping too, but I also dislike having code to support both the old path and the new one basically forever.

There's also support for $XDG_CONFIG_HOME in-place already. It has a similar structure: $XDG_CONFIG_HOME/Bitwarden CLI aka $HOME/.config/Bitwarden CLI

Interestingly the new (beta) BW Secrets Manager currently uses $HOME/.bws:

https://github.com/bitwarden/sdk/blob/0aa7ee030f44b5b23a15998524ac8f638160ed46/crates/bws/src/config.rs#L43-L44

I searched issues and can't find anyone other than four of us that have ever (vocally) cared. lol

Hmm.