bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.21k stars 1.24k forks source link

No prompt (add login notification) offered to save the credentials for some sites #320

Closed Moxville closed 3 years ago

Moxville commented 7 years ago

Hi Kyle,

Today I tried adding credentials for some new sites via. extension. For some sites I got the prompt and for some sites I did not get the prompt a) The prompt I get to save the credentials is not constant "Should bitwarden remember this password for you?". During site login time the prompt appears and disappears few times (not constant). Eventually I could click the button to save the credentials. But i think the "prompt" should be constant until the user decides

b) For below mentioned sites I logged-in i did not see this prompt "Should bitwarden remember this password for you?" . I tried few times again but no prompt to save the credentials https://www.isaca.org https://forum.glasswire.com/ https://ebiz.licindia.in http://www.m-hddl.com/ https://mega.nz/ https://www.overclock.net/login https://freescan.qualys.com/freescan-front/ https://www.scribd.com/ https://www.snapdeal.com/ https://home.sophos.com/ http://www.timesjobs.com http://www.vn-zoom.com/ https://www.sevenforums.com/ http://forum.pdf.wondershare.com/

Browser I use Vivaldi 1.12.955.38 (Stable channel) (32-bit) Bitwarden extension v1.19.1 (installed)

xeor commented 3 years ago

@xeor I appreciate the offer, but for now I think it's on us to improve the detection algorithm for the save prompt. The help wanted tag still applies if anyone has the skills & time to dive into the code (but we're working on it at our end either way).

This issue is old, and it might be time to attack the problem from multiple angles?

Community can help with pushing on the site-owners, what about making a procedure for how we can complain to them, and what we can ask them? I bet a lot of pages want to support password-safes, but they are not aware how to..

We can help with specific sites, making regex, xpath or javascript queries for detecting forms on specific sites. But where can we give those specific back to you, the app-makers? What about making an issue-template for that with some info? At least a label?

For the users that sees these problems.. What about a function in the app to report a broken page?

There are more and more clipboard managers lurking around as well, so not having a stronger focus on this problem will only push our passwords into the clipboard-managers history, which is a bad thing...

Please, some urgency!

cscharf commented 3 years ago

We can help with specific sites, making regex, xpath or javascript queries for detecting forms on specific sites. But where can we give those specific back to you, the app-makers? What about making an issue-template for that with some info? At least a label?

For submitting issues on specific sites to us, please consider visiting this issue which has a link to a form for reporting these: https://github.com/bitwarden/browser/issues/1620

For the users that sees these problems.. What about a function in the app to report a broken page?

Will have to give this some thought, but not a bad idea either.

Overall this has been an intermittent issues with several sites working then not working, then working, our team not being able to reproduce failures, etc. We are now starting to dedicate resources to tackling it and hope to start making marked improvements soon. Thanks!

eliykat commented 3 years ago

Thanks everyone for your feedback in this thread. This is a known problem that affects a number of sites, and we’re working on improving this feature. To help us track and analyze affected sites, please lodge a report using the Google Form mentioned in this issue: #1620. Please also direct any discussion or questions to that issue. This issue will now be closed.

kevinjmcmahonjr commented 3 years ago

I just tested this out on Yahoo and Protonmail and whether creating a new account or updating an existing account I got no prompt... This now requires me to set the clear clipboard setting to much longer than the 20 or 30 seconds I was planning on setting it to. In both test cases I didn't have enough time to save the password that was generated and copied to the clip board and then trying to change the password on a newly created account was not a fun time. I'm going to set it to 5 minutes for now I suppose.

I'm coming from LastPass and I already paid for their service so I'm not one of the many flocking to BitWarden because LastPass has changed their free service. I've been paying for it for 5 or more years. I'm just evaluating for myself to make recommendations to others and to see if Bit Warden works better for me as there are plenty of things LastPass annoys me with.

This is a huge issue and makes it hard to recommend to less tech savvy people. Yes, this issue exists with all password managers but I'm truly disappointed to see how poorly it is working with Bit Warden, this is my only major complaint so far. I'm going to continue to use it for myself to see what else bothers me, but I just know for a fact this is a deal breaker to too many other people especially when LastPass just works 90% of the time. LastPass is also significantly better at auto-filling user name and passwords.

I submitted both sites to the Google Form.

I hope this gets further improvement, I know how difficult it is to make this work on all sites, but other password managers have done better with it. If I knew how to fix it I'd contribute, but that's for people smarter than me to figure out.

djsmith85 commented 2 years ago

Hi @akasnilhaq77 this issue was closed to combine the reports into https://github.com/bitwarden/browser/issues/1620. This makes it easier to track these kind of things. Please have a look there and add all details to the report, if this is still an issue.

A hint for now, if the extension is locked then no save prompt appears. This was fixed and will be available in the next release which will be rolled out in the next couple of days.