bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.27k stars 1.25k forks source link

Chrome's WebAuthn dialog is clipped within the extension popup #4365

Closed ngparker closed 1 year ago

ngparker commented 1 year ago

Steps To Reproduce

  1. First, on Chrome, use several mobile devices to authenticate to sites while logged into Chrome and syncing. This will add several options to the Chrome WebAuthn chooser dialog. You can also use Stable + Canary Chrome on Android to ensure you've got several "phones" listed.
  2. Ensure your BitWarden account has some WebAuthn methods configured
  3. Log into the Chrome Extension (I did on ChromeOS) with master password, then it asks for WebAuthn auth.

Expected Result

I expected the Chrome popup to show all the auth method options without being clipped by the bottom and right edge of BitWarden's extension popup.

Actual Result

The "manage devices " button is partially obscured because the extension popup is too short, and there's no scroll bar. Then on the next authentication screen it obscures even more, but I failed to get a screenshot.

I'm not sure if the best solution here is for the dialog to be bigger to provide sufficient space, or if somehow the Chrome authentication dialog should pop out of the extension dialog (a Chromium feature req). The latter could be problematic since it would be less clear what app/site/extension it was attached to. Adding a scrollbar seems like the minimum requirement to make it usable.

Screenshots or Videos

image

Additional Context

No response

Operating System

Linux

Operating System Version

ChromeOS 107.0.5304.110 (Official Build) (64-bit)

Web Browser

Chrome

Browser Version

107.0.5304.110 (Official Build) (64-bit)

Build Version

2022.12.1

Issue Tracking Info

Hinton commented 1 year ago

Hi,

We changed the WebAuthn behavior in #4695 to resolve another issue. This means WebAuthn prompts are now handled in a regular browser window and this overlap should no longer appear. Closing this as resolved.