Does not auto-fill username fields of type "number"

riaanduplessis commented 1 year ago

Steps To Reproduce

Go to https://ehome.dha.gov.za/
Autofill with any credentials using the extension

Expected Result

Username field gets filled

Actual Result

Only password is filled and username remains blank

Screenshots or Videos

No response

Additional Context

It may happen that some websites may use a number input type for their username field, this can be for something such as an ID number.

Currently, the extension limits the field types it checks to:

text
email
tel

Reference to the code:

https://github.com/bitwarden/clients/blob/dcc7846138c48a55eec774d00564b489edaeb83c/apps/browser/src/autofill/services/autofill.service.ts#L1159-L1172

Operating System

macOS

Operating System Version

No response

Web Browser

Chrome

Browser Version

No response

Build Version

2023.1.0

Issue Tracking Info

[X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

SergeantConfused commented 1 year ago

Hi @riaanduplessis,

Thank you for reporting that. I am unable to access that URL (https://ehome.dha.gov.za/), even via a VPN. Could you please let me know if you're able to autofill that webpage by using a Custom Field (https://bitwarden.com/help/custom-fields/)?

Thank you in advance,

riaanduplessis commented 1 year ago

@SergeantConfused Hmm, might be because it's a government website.

Custom field works, yes. I believe the custom field autofilling doesn't have the same type restriction as the username field.

SergeantConfused commented 1 year ago

Hi @riaanduplessis,

Thank you. I recommend you use custom fields for such Login flows; I will keep this tracked internally to see if there is a need for the standard Username field to support additional classifications.

All the best,

riaanduplessis commented 1 year ago

@SergeantConfused Thanks for the feedback.

Yeah, I mainly opened the issue because I thought it made sense to allow this and avoid having to use a custom field.

If you'd like, I can do a PR for this? Then it is there if you guys decide to go with this.

SergeantConfused commented 1 year ago

Hi @riaanduplessis,

Sure thing. If you'd like to work on addressing this, please free to do so; I recommend starting here (https://contributing.bitwarden.com/).

All the best,

bitwarden / clients