search

bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.02k stars 1.18k forks source link

Search results should prioritize titles over usernames #489

Closed Phanx closed 6 years ago

Phanx commented 6 years ago

When searching in the extension popup, entry title matches should be prioritized over username matches. For example, searching for "protonmail" brings up dozens of entries where the username is my email address, while the actual login entries for ProtonMail require a lot of scrolling to get to. This is also a problem for Gmail, albeit a less annoying one because "G" comes earlier in the alphabet than "P"; I imagine it's also much worse for Yahoo mail users.

The sorting algorithm needn't be terribly advanced; it could simply show all title matches before all username matches.

Related: #376 - Search should look at usernames

kspearrin commented 6 years ago

There are plans to overhaul the search, which is quite basic in it's current implementation, to use something like https://lunrjs.com/

kspearrin commented 6 years ago

We are moving away from tracking Bitwarden feature requests like this one as GitHub issues. We have created a Bitwarden Community Forum which has a section for submitting, voting for, and discussing product feature requests. Please sign up on our forums if you want to continue contributing to feature requests.

Since this was a popular feature request we have already re-created it on the forums and linked back to this GitHub issue for reference. You can vote for this feature request there if you'd like.

https://community.bitwarden.com/t/advanced-vault-searching/36

This issue will now be closed. Thanks!