bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.32k stars 1.26k forks source link

Weak password report unresponsive/very slow #5603

Open johanvdw opened 1 year ago

johanvdw commented 1 year ago

Steps To Reproduce

When a lot of secrets are stored inside the vault, the weak password report becomes unresponsive. When approximately 10 passwords are there, the report opens quickly without issue. With 50 passwords - the report does not show after one minute or so, and the browser tab is becoming stale.

Expected Result

It looks like the report is taking excessively long to generate, I would expect it to increase linearly with the number of passwords, but it grows faster. If it does take long some kind of progress would be useful.

Actual Result

The browser becomes unresponsive.

Screenshots or Videos

No response

Additional Context

No response

Operating System

Linux

Operating System Version

No response

Web Browser

Chrome, Firefox

Browser Version

No response

Build Version

2023.3.0

Issue Tracking Info

Krychaz commented 1 year ago

Hello there,

I just tested this with a vault that has 5,000 items. I was not able to replicate the issue. Could you please test this on another browser and incognito mode?

johanvdw commented 1 year ago

I tested it and I can reproduce the behavior - Will try to do some extra tests to see if there is a record that causes this behavior.

Krychaz commented 1 year ago

Opening dev tools when the report is stuck loading should produce some errors in this case

johanvdw commented 1 year ago

FYI, no errors are reported in the console - opening in incognito does not help.

benni347 commented 1 year ago

Hey, I'm experiencing the same issue on both macOS X (Version 13.6 (22G120)) and Arch Linux. I've tested it on Firefox, Safari and Chrome, and both browsers exhibit the same problem. I've set my KDF key iteration to 100,000 and am using the PBKDF2 SHA-256 algorithm. My account contains 1,200 passwords, with each password being approximately 45 characters long. I'm using web vault version 2023.8.2. No errors are showing up in the developer tools for either Firefox or Chrome. I also tested it in the incognito mode, same behavior.

johanvdw commented 1 year ago

Trying to figure out other reasons

benni347 commented 1 year ago

I tested it with a new account, exported my vault 1200 password, imported it there, still unresponsive so I think it has nothing to do with organisations.

tendervittles commented 11 months ago

Weak passwords is also extremely slow for me.

I have 600 passwords and no organizations.

Same for me on Firefox or Chrome, on Windows 10 and MacOS Ventura.

tendervittles commented 2 months ago

I found my problem.

I had a login with an extremely long JWT for a password.

I switched this over to a note and everything was fine.