bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.31k stars 1.26k forks source link

Safari: password reprompt window stays open when tabs are pinned #6707

Open hausler89 opened 1 year ago

hausler89 commented 1 year ago

Steps To Reproduce

  1. Pin tabs in Safari
  2. Lock the vault of the browser extension
  3. Hit Shift-Command-L, enter PIN / Password

Expected Result

The vault should be unlocked, and the little popup window where you entered the password should close.

Actual Result

The popup window stays open in the background.

Screenshots or Videos

No response

Additional Context

It works as intended when there are no pinned tabs. However, when tabs are pinned, the popup window for the password prompt only moves to the background instead of being closed.

This is particularly annoying when you have a short timeout on the vault, as it will create a new window every time you use autofill and put in the password. Even worse is using biometrics, as each of the windows in the background tries to request the fingerprint all the time.

Operating System

macOS

Operating System Version

Sonoma 14.0

Web Browser

Safari

Browser Version

Version 17.0 (19616.1.27.211.1)

Build Version

2023.9.1

Issue Tracking Info

Krychaz commented 1 year ago

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

Jamie4224 commented 1 year ago

Edit: I sideloaded version 23.10.0 which includes https://github.com/bitwarden/clients/pull/6600 and that fixed my issue.

Hi! This issue is also present on Chrome. In my case it is because I use a Chrome tab manager which uses a pinned tab in every window for tab management.

To reproduce:

  1. Install Tablerone Tab Manager
  2. Install Bitwarden Vault Extension
  3. Login to Bitwarden
  4. Lock your vault
  5. Autofill a login with the vault locked (A new window will open to enter your bitwarden details.)
  6. Enter bitwarden login. (On successful details the tab will close and focus will go to the tab in which you used autofill (in the original window), the newly created window will stay open on the pinned tab.

This means that every time you use autofill on a locked vault, you create a new window which you need to manually close.

Previously I did not have this issue because bitwarden opened a new tab in the same window, which works fine.