bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.28k stars 1.25k forks source link

"No supported key algorithms were found #6804

Closed agelwarg closed 2 months ago

agelwarg commented 1 year ago

Steps To Reproduce

  1. Go to https://accounts.zoho.com/home#multiTFA/modes
  2. Scroll down to Passkey
  3. Click on "Set up Now"
  4. Give the new passkey a name and click "Next"

Expected Result

New Passkey added

Actual Result

Failure

Screenshots or Videos

image

Additional Context

No response

Operating System

macOS

Operating System Version

Sonoma 14.1

Web Browser

Chrome

Browser Version

118.0.5993.117

Build Version

2023.10.0

Issue Tracking Info

micaelvaleri commented 1 year ago

Same with Bitwarden add-on Version: 2023.10.1 on Brave Version 1.60.110 Chromium: 119.0.6045.105 on Linux Mint 21.1 Vera

Neonwarden commented 1 year ago

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

micaelvaleri commented 1 year ago

Kayak.com gives a similar error "It looks like your current browser does not support passkeys. You can still add a passkey to your KAYAK account from another device."

Neon-44 commented 12 months ago

same on Firefox and Mangadex.org

but i am really hyped we finally got Passkeys, big thanks to the Engineer Team. I really appreciate your work :):)

your work is totally worth the Price for Premium :):)

vijay-prema commented 12 months ago

I'm seeing the same issue with zoho, in both Firefox and Chrome on Ubuntu 2204. Bitwarden passkeys works for other sites like github and Google. Only zoho has this issue so far.

Zikinn commented 11 months ago

Microsoft 365 Business Account (myaccount.microsoft.com) shows the same error, unable to add Bitwarden Passkey,.

ocrete commented 10 months ago

I'm seeing the same thing with our corporate keycloak instance.

markesss commented 10 months ago

I was just testing Keycloak with WebAuthn, and found that Keycloak JS is assembling the publicKey.publicKeyCredParams array as [{alg: "-7", type: "public-key" }], assembling the alg property as a string, instead of an integer....

When its passed through to Bitwarden (specifically, lib/common/src/vault/services/fido2/fido2-client.service.ts:115) the key algorithms are filtered out because they're not matching a supported key algorithm {alg: -7, type: "public-key"}

Hope this helps save someone some time, I probably spent more time than I should have trying to figure out where the problem was, suspecting it was my configuration in Keycloak!

DianaNites commented 10 months ago

Also hit this issue, apparently it should be fixed in keycloak 22.x onwards via https://github.com/keycloak/keycloak/pull/20832, if sites would only update to working versions.

Neon-44 commented 10 months ago

Soooo....

What are we going to do?

Are we going to try and parse the Strings or do we insist that the providers have to fix their side?

markesss commented 10 months ago

It looks like the browser native api handles both, otherwise none of these implementations would have made it to production even though they are technically incompatible…

For usability and adoption, Bitwarden should probably adapt its tests to handle string or integer values here. Even if it is a deviation from the standard, otherwise it would prevent Bitwardens passkey implementation from being adopted.

Just my 2c of course

foxt commented 9 months ago

I think another problem is that if Bitwarden fails to parse the request it hard fails instead of passing it to the browser

BluCobalt commented 8 months ago

I have the same issue when trying to create a key on Oracle Cloud, on Windows. Opening a private browser tab (trying without bitwarden) makes it go through and it works.

tuanson84uk commented 8 months ago

Screenshot 2024-03-07 093947

The same happened when registering on OCI - Oracle Cloud Infrastructure.

bohanyang commented 7 months ago

Same for me on Oracle Cloud

DianaNites commented 5 months ago

This is still an issue, and the fix has still not been merged. Many websites are unfortunately still using broken versions of keycloak, or other broken implementations, and show no signs of updating.

good-live commented 5 months ago

Yeah im also facing issues on multiple sites. Would be great to have a fix from Bitwarden site. Especially because the bitwarden extension blocks use of some other passkey provider.

ralstonba commented 4 months ago

Status? #7832 hasn't received any feedback, what is preventing progress on this?

supleed2 commented 2 months ago

I saw that a fix was supposedly merged, and it seems a new version has been released since then (which I am running, 2024.8.1), but I'm still seeing this issue on Oracle Cloud Infrastructure like in https://github.com/bitwarden/clients/issues/6804#issuecomment-1982233352

Is this resolved with the other websites mentioned?

mjesticfalco commented 2 months ago

I saw that a fix was supposedly merged, and it seems a new version has been released since then (which I am running, 2024.8.1), but I'm still seeing this issue on Oracle Cloud Infrastructure like in #6804 (comment)

Is this resolved with the other websites mentioned?

Mangadex, which uses Keycloak, is also still having this issue.

xvyvx commented 1 month ago

As mentioned above, this problem is still exists when enable passkey on zoho.com(2024.9.0 on chrome 128.0.6613.138).

Ephemera42 commented 1 month ago

https://github.com/bitwarden/clients/commits/browser-v2024.9.0/apps/browser/src/vault/fido2/webauthn-utils.ts https://community.bitwarden.com/t/just-released-new-inline-auto-fill/61436/80

The fix is not included in the latest version. I guess it will come with the next major release.

DianaNites commented 1 month ago

It'd sure be nice if issues were only closed when they're actually fixed and not affecting people anymore, rather than a month beforehand just because some commit somewhere exists that fixes it only in theory but in practice its still broken.

not sure the relevance of whatever "inline autofill" is, that thread doesn't mention this issue at all either? This issue is about passkeys simply not working at all period no matter what on some major websites due to some browsers implementing the spec incorrectly and encouraging websites to be broken in the same way, meaning everyone needs to have a workaround for it now, which bitwarden does not yet have. Thanks, browsers.

Camis commented 2 weeks ago

In the latest version of
browser-v2024.10.1

“Bug” has been corrected and you can now set Passkey on Zoho among others.

mjesticfalco commented 2 weeks ago

Can also confirm that Mangadex is also working, meaning that Keycloak should also be good to go on browser-2024.10.1

agelwarg commented 2 weeks ago

Confirmed working for Zoho. FWIW, I'm still on v2024.10.0. I don't know where any release notes are that would call out this particular bug, but nonetheless, it is now working...recently.

agelwarg commented 2 weeks ago

I went back and stepped through comparing the releases and it looks like this was fixed in v2024.9.1.

https://github.com/bitwarden/clients/compare/browser-v2024.9.0...browser-v2024.9.1

(Look for changes to apps/browser/src/autofill/fido2/utils/webauthn-utils.ts)