bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.04k stars 1.19k forks source link

Left Navigation Edit Folder Icon does not display on very long folder names #6811

Open foxinSOCKS5 opened 10 months ago

foxinSOCKS5 commented 10 months ago

Steps To Reproduce

Description of Issue

On MacOS desktop client Version 2023.9.1 (12289), if a very long folder name(especially with wide characters) appear in the left-nav DIV, Edit Folder icon does not display in the navigation bar.

  1. Create a new folder with a name like 5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D5D
  2. Select the newly created folder in the Left Navigation bar and observe that the Edit Folder icon is not visible

Expected Result

Edit Folder Icon is visible to users when any folder is selected under the FOLDERS filter in the left navigation.

Actual Result

no-edit-folder-icon

Screenshots or Videos

No response

Additional Context

Potential workaround for the issue:

  1. While desktop client is open, hit F12 key to bring up developer tools

  2. Select the inspector icon from the top left corner (or hit CMD+Shift+c)

  3. Highlight the left navigation bar to expose <div class="left-nav"> HTML tag under the Elements tab and then select it

  4. From the Styles window on the right locate .left-nav { CSS properties and uncheck width and max-width properties

    css-edit
  5. Left navigation bar will expand to display the full name of the longest folder

  6. Locate the edge of the Edit Folder icon in the navigation bar and click it to expose the Edit Folder modal

    expanded-nav
  7. Click Delete icon in the modal

    edit-folder-modal

Operating System

macOS

Operating System Version

Sonoma 14.0

Installation method

Direct Download (from bitwarden.com)

Build Version

Version 2023.9.1 (12289)

Issue Tracking Info

TroyBW commented 10 months ago

Hi there,

Thank you for your report! I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!