bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.99k stars 1.18k forks source link

Unable to auto-fill #6832

Closed DjKilla2 closed 10 months ago

DjKilla2 commented 10 months ago

Steps To Reproduce

  1. Go to 'various web sites'
  2. Click on 'login or fill form'

Expected Result

Logins and forms should be filled in.

Actual Result

Logins and forms aren't filled in or fields within forms aren't filled in.

Screenshots or Videos

No response

Additional Context

Auto fill issues with version 2023.10.1. I’m using Firefox 119.0.1 and multiple web site forms are either unable to fill the form or some fields in the form are not filled in. Never had any issues filling the form with previous versions. I’m guessing Microsoft Edge has the same issues.

There's lots of posts on the Bitwardin Community Forum about this issue.

https://community.bitwarden.com/t/unable-to-auto-fill-the-selected-item/59916/8

https://community.bitwarden.com/t/autofill-problem-with-schwab-com/59938/2

Operating System

Windows

Operating System Version

Windows 10 Home 22H2 64-bit

Web Browser

Chrome, Microsoft Edge, Firefox, Brave

Browser Version

No response

Build Version

2023.10.1

Issue Tracking Info

cagonzalezcs commented 10 months ago

@DjKilla2

Thank you for the bug report, can you please link a couple of these various sites that you are referencing?

We have a known issue that was introduced by work that optimized the collection of page details which has been fixed for the next release. However, if other issues are present I'd like to know so that we can resolve them ASAP within the current sprint.

ghost commented 10 months ago

I'm using Chrome browser and I'm having the same problem. After the 2023.10 update, autofill does not work on many sites. When I open Bitwarden and click on the existing account it shows an error message.

Also, the CTRL+Shift+L shortcut no longer works.

Screenshot ![filen-bug](https://github.com/bitwarden/clients/assets/147916475/5c40a82f-d53e-4a95-af75-9d5c23c93d78)
pardub commented 10 months ago

Exact same issue from today on Firefox with Bitwarden extension 2023.10.1.

bwbug commented 10 months ago

@cagonzalezcs

Based on recent reports in the user community spaces, some examples of sites where the auto-fill functionality appears to have broken include:

There are also other reports, in which users are vague about what sites are broken.

cagonzalezcs commented 10 months ago

@bwbug Thank you for providing those, yeah in each of the cases the bugfix linked above resolves the issue.

To mitigate the recent concerns that have been appearing, we've flipped off a feature flag that introduced these optimizations until we can resolve the problems encountered and release them.

To ensure that you are loading the older version of autofill, please re-sync your vault through the browser extension and reload the page that you are attempting to autofill on. This should update the feature flag reference in your extension, and trigger loading of the old version of autofill when visiting a web page.

EDIT: I'll keep this thread open until I get some confirmations that this resolved the issue. If it does not, we'll jump back into investigating a resolution.

bwbug commented 10 months ago

To make sure I understand, you are saying that the auto-fill behavior of the currently installed browser extension version (e.g., 2023.10.2) can be changed/fixed without upgrading or downgrading to a different version? Simply syncing the extension changes the code it uses?

cagonzalezcs commented 10 months ago

In this specific instance, yes that's correct. We architected the refactor of autofill.js with the intent that if anything went wrong in the v2 version, we could quickly fallback to the v1 version of the feature. Autofill v2 has been active in production for about a month at this point, but this recent release introduced the first true improvements to the feature.

As we are encountering issues, we are flipping back to the v1 implementation until we can resolve the problem through either a hotfix or standard release. Currently, the only difference between v1 and v2 is the ability to fill ShadowDOM elements (which was introduced with the most recent release).

So with that said, users will need to sync the extension to immediately update that feature flag.

bwbug commented 10 months ago

Cool! And yes, I've confirmed that it works (for the sites I listed above).

DjKilla2 commented 10 months ago

I'm a little late replying but here's some additional info. At the moment, auto-fill is working again in Firefox 119.0.1 with Bitwardin 2023.10.1 probably because the v1 was re-implemented. You wanted some additional links so I'll do my best to post a few that I remember.

https://medicinecabinetamoe.com/ https://www.reddit.com/ (logging in) https://www.verymerrymartins.com/ https://www.littlepotatoes.com/holiday-happiness/ https://www.ramseysolutions.com/giveaway/ramsey-cash-giveaway https://www.midwestliving.com/tailgatesweeps

Either the forms did not fill in or some fields weren't filled in or logging in (username/password) did not fill in. There's lots more than this but I would need to test v2 to list more web sites.

cagonzalezcs commented 10 months ago

@DjKilla2

Thank you, that's incredibly helpful. I can confirm that the fix we have in place within the master branch allows autofill to occur on all of those URLs.

I'm closing this thread for now, please let me know if any other unexpected issues present themselves. We can re-open the thread if necessary.

Lunchtime0614 commented 10 months ago

I am still having the same non auto-fill issue. schwab.com as example. I have 2023.10.1 extension version installed on Librewolf on Debian. I force synced it then reloaded schwab and received the auto-fill error. If I downgrade the extension it works....just as it has in the past.

cagonzalezcs commented 10 months ago

I am still having the same non auto-fill issue. schwab.com as example. I have 2023.10.1 extension version installed on Librewolf on Debian. I force synced it then reloaded schwab and received the auto-fill error. If I downgrade the extension it works....just as it has in the past.

Could you try a different browser and see if the problem persists with the 2023.10.x extension? It's possible that some kind of cache for the value is still present on your browser...

I just tested within Chrome on v2023.10.2 and am able to autofill.

Lunchtime0614 commented 10 months ago

I am still having the same non auto-fill issue. schwab.com as example. I have 2023.10.1 extension version installed on Librewolf on Debian. I force synced it then reloaded schwab and received the auto-fill error. If I downgrade the extension it works....just as it has in the past.

Could you try a different browser and see if the problem persists with the 2023.10.x extension? It's possible that some kind of cache for the value is still present on your browser...

I just tested within Chrome on v2023.10.2 and am able to autofill.

Tried with Firefox as well - it worked once, then when I re synced the extension and the page it gives me the red auto fill error within the extension. Tried on windows 11 with firefox too - same issue. Deleted all history/cache and it still gave the same error.

I have another site that its still not working for too - but no point listing it as it's not public - it's a web login only accessible within my company's LAN. Downgrading to the previous version works however.

cagonzalezcs commented 10 months ago

@htims05 So this is going to sound like an odd request... but are you able to autofill auth.max.com with some credentials?

If that's the case, then somehow you're still using the autofill v2 script to trigger fill... I'm not sure on how that would be the case, unless somehow the tool we are using for feature flagging takes time to propagate changes... we'd have to investigate if that were the case, but it would also mean that you eventually would receive an update to the flag value (I know that's not a great solution by any means).

Lunchtime0614 commented 10 months ago

@htims05 So this is going to sound like an odd request... but are you able to autofill auth.max.com with some credentials?

If that's the case, then somehow you're still using the autofill v2 script to trigger fill... I'm not sure on how that would be the case, unless somehow the tool we are using for feature flagging takes time to propagate changes... we'd have to investigate if that were the case, but it would also mean that you eventually would receive an update to the flag value (I know that's not a great solution by any means).

I was able to just click the + in the extension while on auth.max.com and enter a random username / password....it did auto-fill.

cagonzalezcs commented 10 months ago

Right, so that shouldn't be possible to do if you were on autofill v1.

Somehow your client is still receiving the feature flag for v2, and not updating. I'll look into it to see why that might be the case, but downgrading for now will be the alternative fix for now.

Are you self-hosting your server by chance? Or potentially connecting to the EU cloud server?

bwbug commented 10 months ago

@cagonzalezcs

Are you self-hosting your server by chance? Or potentially connecting to the EU cloud server?

Just to be able to give out accurate information when helping users in the community forums, does the above question imply that the fix involving the change of the v2 feature flag to v1 is not currently available for users whose accounts are self-hosted, or hosted on bitwarden.eu? Will the feature flag be updated for those users, as well, at some point?

Lunchtime0614 commented 10 months ago

Right, so that shouldn't be possible to do if you were on autofill v1.

Somehow your client is still receiving the feature flag for v2, and not updating. I'll look into it to see why that might be the case, but downgrading for now will be the alternative fix for now.

Are you self-hosting your server by chance? Or potentially connecting to the EU cloud server?

Self-hosted.

cagonzalezcs commented 10 months ago

I see, yeah that would make sense.

I spoke with one of our other devs who is more familiar with self hosted instances and he gave the following feedback:

You should be able to create a file, like this:

./bwdata/core/launch-darkly/flags.json

{
  "flagValues": {
    "autofill-v2": false
  }
}

Then run ./bitwarden.sh rebuild && ./bitwarden.sh restart Finally add globalSettings__launchDarkly__flagDataFilePath=/etc/bitwarden/core/launch-darkly/flags.json to ./bwdata/env/global.override.env

This should set the feature flag within your extension from a self-hosted instance.

Lunchtime0614 commented 10 months ago

Is this going to be fixed in a future release for self hosted clients - instead of this one-off modification, it seems I'd be better served to just downgrade the extension and wait for an official fix - if there is one?

bwbug commented 10 months ago

@cagonzalezcs And what about users hosted on bitwarden.eu — will the feature flag roll-back be applied there at some point, as well?

cagonzalezcs commented 10 months ago

Is this going to be fixed in a future release for self hosted clients - instead of this one-off modification, it seems I'd be better served to just downgrade the extension and wait for an official fix - if there is one?

There is a fix for this problem already merged within master. I'm unsure if we are going to hotfix the extension for this however, but I'll confirm with my manager.

And what about users hosted on bitwarden.eu — will the feature flag roll-back be applied there at some point, as well?

As for the EU flag, I'm checking with the team to see if there is a difference between the US and EU servers for this. From my knowledge, there shouldn't be any differences between the two... but I'll report back once I find out more.

Gerardv514 commented 10 months ago

What is the difference in autofill v2?

bwbug commented 10 months ago

@Gerardv514 It seems that the bulk of the V2 development is described in PR 5453. It appears to be mostly a refactoring effort, i.e., cleaning up the code without changing its behavior or features. Subsequent to the roll-out of V2, though, new autofill features/improvements have been developed and implemented only in V2 (not in V1), such as PR 6141 that makes possible autofilling of field elements in a "ShadowDOM" — basically, allowing autofill to work on webpages where it previously did not work (e.g., auth.max.com). Unfortunately, that PR had some unintended side effects, leading to the problems reported in this thread.

cagonzalezcs commented 10 months ago

Just posting to confirm that we use a singular feature flag on both the US and EU servers. Users who are using cloud hosting with Bitwarden should be loading v1 completely.

bwbug commented 10 months ago

@cagonzalezcs Thanks for the update. To check if a user is still "stuck" on v2, is there a site other than auth.max.com available for testing this? It seems that the max.com site is regionally restricted:

image

cagonzalezcs commented 10 months ago

@bwbug Yes, any website that uses custom web components (which leverage the ShadowDOM) can be used as a test.

Another good example is - https://www.royalcaribbean.com/account/signin

jancona commented 8 months ago

I know this issue is old, but I'm experiencing this issue on many sites, starting in the last week or so. For example, I was unable to autofill my Github login in order to comment on this issue. I'm especially seeing it almost every time I try to use a Bitwarden identity to autofill a form. Let me know if I you'd rather I open a new issue.

Bitwarden Version: 2023.12.1 Server Version 2023.12.1 OS version: MacOS Monterey 12.7.2 Browser: Brave using the official extension installed from the Chrome Web Store Browser version: 1.61.109 Chromium: 120.0.6099.144 (Official Build) (x86_64)

EDIT: Additional info

I can autofill at client.schwab.com and auth.max.com.

I've tried uninstalling and re-installing the extension and restarting the browser. Neither helped.

I tried in Firefox. I was able to autofill github.com, which didn't work in Brave. I was unable to autofill my identity on https://www.newfoundlandlabrador.com/trip-ideas/travellers-guide/ in either Brave or Firefox.

cagonzalezcs commented 8 months ago

@jancona

So the issue you're referring to should be resolved in the upcoming release of the Bitwarden extension. I tested autofill with the recently cut release branch, and filling on the link you provided works. The problem does exist for the current extension however, and the fix for that can be seen here - https://github.com/bitwarden/clients/pull/7209

felix2380 commented 8 months ago

Auto -fill does not work in pCloud and must be copied manually.Firefox extension version 2023.12.1.I should mention that I have tried all the auto-fill methods in my pCloud account and it doesn't work.In my Twitter account the auto-fill method [Show auto-fill menu on form fields--When field is selected(on focus) ] it works only partially, username enters but not password,the auto-fill method with Ctrl+Shift+L as well as the other methods work.In my Microsoft outlook account the auto-fill method that is mentioned in the Twitter account doesn't work at all [Show auto-fill menu on form fields--When field is selected(on focus) ] ,Ctrl+Shift+L method and the other methods work too.Thank you very much!

vixrodriguez commented 6 months ago

I installed the Bitwarden Chrome Extension on the Brave Browser, and I found some sites where autofill is not working. Below is a list.

  1. https://www.bancasinhorarios.com.ec/BOLI-ebanking/seguridad/login.htm
  2. https://bancaweb.pichincha.com/pichincha/login
  3. LifeMiles First, click on "Continue with LifeMiles number or username" to visit login website. When the first time page is loaded, the field LifeMiles number or username is empty, but you can choose the username from extension.

If I find other sites, I will create a new comment

bwbug commented 6 months ago

@vixrodriguez Unless you're encountering an auto-fill issue where the auto-fill used to work before November 2023, and subsequently stopped working, you should just use the regular Auto-Fill Failure Report Form. I also encourage you to post in the Ask the Community Forum to seek assistance with run-of-the-mill auto-fill issues.

In your examples, all three websites can be successfully auto-filled using the Ctrl+Shift+L keyboard shortcut. In the case of the second link only (bancaweb.pichincha.com), you also have to define linked custom fields named bb_input_0 and bb_input_0 linekd to the username and password, respectively.