bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.69k stars 1.14k forks source link

Firefox extension prevents proper XML file display #6865

Closed hrunting closed 4 months ago

hrunting commented 8 months ago

Steps To Reproduce

  1. Go to 'this XML file'

Expected Result

In Firefox, this should display a navigable XML document tree.

Actual Result

In Firefox, this renders the text in the nodes found in the XML document, rather than the XML tree itself.

Screenshots or Videos

XML file without Bitwarden extension enabled XML file with Bitwarden extension enabled

Additional Context

This seems to have started with version 2023.10.x. I currently have Firefox 119.0.1 and Bitwarden extension version 2023.10.2. The behavior of XML documents definitely changed within the past two weeks, as XML previously displayed fine.

You can restore the correct browser XML document behavior by either disabling the extension or going to Settings > Excluded domains within the extension and adding the domain of the page.

I have not tested on other browsers.

Operating System

Windows

Operating System Version

Windows 11 23H2

Web Browser

Firefox

Browser Version

119.0.1

Build Version

2023.10.2

Issue Tracking Info

vaionescu commented 8 months ago

I'm having the same issue on Firefox on Linux. I tried downgrading the Bitwarden addon - version 2023.10.1 still has the same issue, but version 2023.9.2 doesn't, so presumably the bug was introduced in release 2023.10.1.

OS: Debian 12 Browser: Firefox 119.0.1 (64-bit) Addon Version: 2023.10.2

SergeantConfused commented 7 months ago

Hi @hrunting,

Thank you for your report. I was able to reproduce this behaviour and I have flagged it to our Engineering team.

If you wish to add any further information, such as screenshots or screen recordings, please feel free to do so at any time - our Engineering team will be happy to review them.

Thank you again,

ChristopherCarver commented 7 months ago

Same exact issue. The ability to look at XML files directly for ServiceNow development is critical. I have to turn off the plugin to do my daily work.

OS: Windows 10.0.19044 Build 19044 Browser: Firefox 119.0.1 Addon Version: 2023.10.2

SjetCraft commented 7 months ago

Same issue with viewing XML files. @ChristopherCarver Downgrading the plugin to version 2023.9.2 is working as a workaround.

OS: Windows 11 22H2 Browser: Firefox 119.0.1 Addon Version: 2023.10.2

le-burger commented 7 months ago

Same issue.

OS: macOS Sonoma Browser: Firefox 119.0.1 Addon Version: 2023.10.2

gaeljw commented 7 months ago

Same here.

OS: Fedora 38 Browser: Firefox 119.0.1 Addon version: 2023.10.2

elisimpson commented 7 months ago

Same.

OS: Windows 11 23H2 Browser: Firefox 120.0.1 Addon: 2023.10.3

ahmadalkhansa commented 7 months ago

Experiencing the same issue.

OS: macOS Sonoma 14.1.2 Browser: Firefox Version 120.0.1 Addon: 2023.10.2

hrunting commented 6 months ago

Now with version 2023.12.0, it also seems to be ignoring the excluded domain list. The site that I was having this problem with was in my excluded domain list, and now Bitwarden is injecting a script into it.,

It's getting worse, guys. Any update?

dan2097 commented 6 months ago

Same OS: Windows10.0.19045 Build 19045 Browser: Firefox 120.0.1 Addon: 2023.12.0

I started noticing this issue a couple of months ago, and was working around this issue using the excluded domain list, but this is also no longer working for me

kepstin commented 6 months ago

A Firefox issue regarding a different extension: Bug 1605657 provides some technical information about why this happens:

FWIW, this looks to me like a compat issue between the react devtools and our XML pretty printer. The pretty printer turns itself off if anything modifies the DOM ( https://searchfox.org/mozilla-central/rev/8f7b017a31326515cb467e69eef1f6c965b4f00e/dom/xml/nsXMLPrettyPrinter.cpp#147 ), which the react devtools do because they insert a Githubissues.

  • Githubissues is a development platform for aggregating issues.