search

bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.03k stars 1.19k forks source link

Firefox addon: TOTP not automatically copied #7275

Open falolaf opened 9 months ago

falolaf commented 9 months ago

Steps To Reproduce

  1. Configure addon to automatically copy TOTP
  2. Visit a site for which TOTP has been enabled. E.g. community.bitwarden.com
  3. Click on "Login"
  4. Ctrl+Shift+L to paste username and password
  5. Ctrl+V to paste copied TOTP

Expected Result

TOTP is pasted in the TOTP field.

Actual Result

Whatever is in copy buffer is pasted.

Screenshots or Videos

Entry in BW before Ctrl+Shift+L has been used: before

Entry in BW after Ctrl+Shift+L has been used: after

Additional Context

Before Ctrl+Shift+L has been used it is possible to copy the TOTP by clicking on the TOTP symbol. (The little clock.) After Ctrl+Shift+L has been used the TOTP symbol has been grayed out and it is not possible to copy the TOTP by clicking on the symbol. I have to enter the entry to do the copy.

Operating System

Windows, Linux

Operating System Version

Windows 10. openSuse Leap 15.5

Web Browser

Firefox

Browser Version

Firefox 120.0 and 115.5 ESR

Build Version

2023.12.0

Issue Tracking Info

PascalHullin commented 9 months ago

Hello,

You are not alone. I do a have the same issue since for some days. I didn't correlate with the new version of the browser plugin update since it autoupdates in background but I can reproduce it with on 3 different machines :

How to reproduce : 1 - navigate to a website that requires a TOTP code and where the plugin worked before. 2 - Unlock the plugin (code or touchID) 3 - Click on the plugin. At that stage the TOTP icon is blue for the record 4 - Click on the record to autofill the ID+Pwd 5 - Paste the clipboard in the TOTP entry form and you get what was in it before instead of the TOTP code. From that stage the TOTP icon of the record is grey out like if were not setup !!!

6- To overcome the problem you need to open the record and copy the TOTP code from the record form and paste it into the web site entry field.

This behaviour is clearly a regression since it was working fine before.

Krychaz commented 9 months ago

Hello there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

PascalHullin commented 9 months ago

I added extra test information I did in another related thread : https://community.bitwarden.com/t/crtl-v-and-ebay/61004/6

It confirms that clipboard contains is not updated with the TOTP code.

falolaf commented 8 months ago

I now have version 2024.1.0 in Firefox and I see there have been some changes to this. The TOTP is still not copied as it should. Though, I don't have to enter the entry to copy the TOTP any longer. It is now possible to click on the TOTP symbol to copy the TOTP. This is a step forward but not the full solution.

Any updates on when this will be fixed?

azulskyknight commented 8 months ago

Confirming I'm suffering from this issue too, and has been persistent since the December update.

I really would like this fixed please, it's seriously disruptive to my workflow.

0oWow commented 8 months ago

Hi all, throwing my two cents in. I experience this problem also on Windows 11 in Firefox Beta 122b9 (haven't tested other browsers). It seems to be related to enabling "show auto-fill menu on form fields". If I turn that option to "when field is selected on focus" or "when auto-fill icon is selected", the TOTP does NOT copy. However, if I turn that option to "OFF", the TOTP copies to clipboard.

I'm taking a wild guess here, but from observation it seems like Bitwarden is caching the credentials to the page on load in some way. I say this because I can have a login page loaded up, but then I change the password in Bitwarden, and even though I click the icon again to autofill, it uses the old password. I have to refresh the page for the new password to kick in. My guess is TOTP can't be cached in the same manner because it changes too quickly, so it glitches out and doesn't copy.

falolaf commented 8 months ago

Hi all, throwing my two cents in. I experience this problem also on Windows 11 in Firefox Beta 122b9 (haven't tested other browsers). It seems to be related to enabling "show auto-fill menu on form fields". If I turn that option to "when field is selected on focus" or "when auto-fill icon is selected", the TOTP does NOT copy. However, if I turn that option to "OFF", the TOTP copies to clipboard.

I'm taking a wild guess here, but from observation it seems like Bitwarden is caching the credentials to the page on load in some way. I say this because I can have a login page loaded up, but then I change the password in Bitwarden, and even though I click the icon again to autofill, it uses the old password. I have to refresh the page for the new password to kick in. My guess is TOTP can't be cached in the same manner because it changes too quickly, so it glitches out and doesn't copy.

This workaround does not work for me. I had that option set to OFF already. I did test to set to the other values and then back to OFF again but TOTP was never copied. I am on FF 115.6.0esr though so that might have some impact.

insidesources commented 7 months ago

I have the same issue in linux +firefox + browser extension - has there been any update to this?

0oWow commented 7 months ago

The latest update, version 2024.2.0 resolves this and is working great. Thanks!

falolaf commented 7 months ago

Does not work for me with 2024.2.0, FF 115.7.0esr, Windows 10. I have reinstalled the addon, to no avail.

insidesources commented 7 months ago

this started to work for me using linux + firefox + browser plugin 2024.2.0 - thank you

PascalHullin commented 7 months ago

plugin 2024.2 does not fix the problem for me, neither on safari or Chrome or Firefox on OSX 14.2.1

falolaf commented 7 months ago

Does not work for me with 2024.2.0, FF 122.0.1, openSuse Leap 15.5.

falolaf commented 6 months ago

Does not work for me with 2024.2.1, FF 115.8.0esr, Windows 10.

ryanelliottsmith commented 6 months ago

Also affected, 2024.2.1. Arc on macOS, and Opera on Windows 11

Edit: Nevermind, I see a "Copy TOTP automatically" setting in the extension that was unchecked. It's either new, or the setting has reverted. Either way, this now works with it checked.

JMenzingaST commented 6 months ago

Also affected, 2024.2.1. Arc on macOS, and Opera on Windows 11

Edit: Nevermind, I see a "Copy TOTP automatically" setting in the extension that was unchecked. It's either new, or the setting has reverted. Either way, this now works with it checked.

Thanks for pointing that out! I also never seen that setting before but now its checked :)

falolaf commented 6 months ago

I have, and have had for quite some time, "Copy TOTP automatically" checked. Tested again to toggle this setting but no luck on e.g.,: https://community.bitwarden.com/

ghhv commented 6 months ago

Same for me on Brave, Firefox and Chrome on Windows 11... Version 2024.3.0 Shell 28.2.4 Renderer 120.0.6099.291 Node 18.18.2 Architecture x64

Extension version 2024.2.1

fmasclef commented 6 months ago

For some reason, "Copy TOTP automatically" self-unchecked on my side. I had to check it by myself. @ghhv Head to parameters, then options to see that setting by yourself.

ghhv commented 6 months ago

@fmasclef arghh! thank-you.. Same! Bloody annoying that was! Has to be reset on every browser too..

falolaf commented 6 months ago

I am really curious why this seem to work for so many others but I have no luck with it! I have tried with reinstalation, toggling the check-box, installed addon in new FF profile, tested on Windows 10 and openSuse, various FF versions. Nothing work!

pjroth commented 6 months ago

The automatic copy of TOTP code to clip board has not worked for me with chrome in months on multiple different computers either.

0oWow commented 6 months ago

I am really curious why this seem to work for so many others but I have no luck with it! I have tried with reinstalation, toggling the check-box, installed addon in new FF profile, tested on Windows 10 and openSuse, various FF versions. Nothing work!

Have you tried Firefox Beta? That's what I use and it works fine. Also, is it just one site your having issue with or every site with TOTP? It could be the one site that is giving you problem. Lastly, the latest version of BW unchecked the copy TOTP option, so you need to reenable it (though I think you are aware of that already).

falolaf commented 6 months ago

@pjroth At least I am not alone with!

@0oWow I have not tested FF Beta. I'll see if I can give it a go but I really don't see why I should have to. I have now tested all sites for which I have TOTP enabled in BW and none work. Ye, I am aware of the issue where copy TOTP option was disabled. I have indeed double checked that.

Bobettemcnugget commented 6 months ago

For some reason, "Copy TOTP automatically" self-unchecked on my side. I had to check it by myself. @ghhv Head to parameters, then options to see that setting by yourself.

I can confirm this was the issue for me as well.

gsstratton commented 6 months ago

issue for me as well, I thought it was because I had switched to flatpaks, but it persists on fully installed, both for firefox and chrome based browsers.

falolaf commented 4 months ago

Today extension got updated to 2024.4.2 in Firefox. Still does not work. And now I again have to open the records to copy the TOTP.

azulskyknight commented 4 months ago

I gave up and upgraded, after getting off my retired Family plan and upgrading to the modern variant all my issues went away.

Bitwarden just needs to admit they aren't supporting old subscriptions anymore, and force everyone to a current plan.

pjroth commented 4 months ago

This still will not automatically copy to clipboard TOTP codes like it used to months ago. I have a family 2019 plan in case that is useful info.

falolaf commented 4 months ago

I gave up and upgraded, after getting off my retired Family plan and upgrading to the modern variant all my issues went away.

Bitwarden just needs to admit they aren't supporting old subscriptions anymore, and force everyone to a current plan.

Is there an official statement of this? I have an old Family plan, same as @pjroth I guess.

GHM3434 commented 2 months ago

Still doesn't copy totp to clipboard autumnally for me either. It's been broken for months.

Windows 11 using Brave and Firefox. Both don't work.

falolaf commented 2 months ago

I also gave in and upgraded from my 2019 family plan to the "new" Family plan. And immediately automatic TOTP copy started to work again.

GHM3434 commented 2 months ago

I also gave in and upgraded from my 2019 family plan to the "new" Family plan. And immediately automatic TOTP copy started to work again.

I am already on family plan and it hasn't worked for like 6 months now or more.

mikex99 commented 1 month ago

When is this going to be fixed? I'm tired of broken entries in my family plan org.

0oWow commented 1 month ago

When is this going to be fixed? I'm tired of broken entries in my family plan org.

This has been working great for a while now. You probably have a configuration that is not normal that needs to be resolved on your end. Otherwise you should probably open a new issue instead of spamming this thread.

mikex99 commented 1 month ago

According to the other family plan 2019 subscribers, the only way they fixed it was by upgrading to a new family plan. This is not fixed for family plan 2019 users.

GHM3434 commented 1 month ago

According to the other family plan 2019 subscribers, the only way they fixed it was by upgrading to a new family plan. This is not fixed for family plan 2019 users.

that makes no sense to me... do you mean close your existing subscription and create a brand new account and subscribe to your plan on the new account?