bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.01k stars 1.18k forks source link

Downloading an attachment, appends a file extension. Even if original file didn't have one #7409

Open jr-m4 opened 8 months ago

jr-m4 commented 8 months ago

Update: This is also present in the Windows Desktop Client. (tested with 2024.08.2)

Steps To Reproduce

In the browser web/interface (Edge):

  1. Add an attachment that doesn't have an file extension e.g. ssh-keyfile or similar e.g "test-file"
  2. Download this attachment "test-file"
  3. Notice that the file downloaded is now called "test-file.txt"

Expected Result

The filename should be conservered, in this case without an extension. This is important when it comes to unix-based files, that often don't use file extensions. I.E in keyfiles and such.

Actual Result

File is renamed and now has an extension. In my example above it has now been given the extension .txt. Which on unix can lead to big issues if not aware!

Screenshots or Videos

No response

Additional Context

No response

Operating System

Windows

Operating System Version

No response

Web Browser

Microsoft Edge

Browser Version

120.0.2210.91

Build Version

Version 2023.12.0

Issue Tracking Info

Krychaz commented 8 months ago

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

gitthangbaby commented 7 months ago

I noticed on the Windows 11, latest, that the extension is added to files without extension: image -> image

jr-m4 commented 1 week ago

Tried it now again. And the bug is still present.

This is also present in Desktop client 2024.08.2