bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.31k stars 1.26k forks source link

The bitwarden logo shows after login for a few seconds on Firefox (MacOS) #8002

Open joshuataylor opened 9 months ago

joshuataylor commented 9 months ago

Steps To Reproduce

I think this has to do with login forms that use Javascript/AJAX for logging in, as the element isn't immediately destroyed, so the input box might still exist in the DOM?

This is very noticeable for slow logins, but have noticed it on quite a few sites, but most reproducible on OpenWRT.

  1. Open a page that uses AJAX logins
  2. Autofill login, the Bitwarden shield icon should show.
  3. Login
  4. The Bitwarden logo stays for 1-10 seconds. SCR-20240219-swwo

Expected Result

The icon disappears as soon as you click login.

Actual Result

The icon stays

Screenshots or Videos

No response

Additional Context

No response

Operating System

macOS

Operating System Version

Sonoma 14.3.1

Web Browser

Firefox

Browser Version

124.0a1 (2024-02-17) (64-bit)

Build Version

2024.2.0

Issue Tracking Info

cagonzalezcs commented 8 months ago

@joshuataylor

Thanks for providing this bug report. We are aware of some issues present with the inline menu on websites that handle DOM re-hydration through AJAX (Such as in the case of SPAs).

Would you be able to provide some specific examples where you're seeing this issue?

joshuataylor commented 8 months ago

OpenWRT seems to the most prevalent for this, I'll see if I can make a reproducible example, as their LuCI web interface uses stock Bootstrap, so in theory it should be straight forward to reproduce.

cagonzalezcs commented 8 months ago

Thanks for those examples. We do have a PR that intends to resolve a different issue that might also help to resolve this lingering DOM element issue.

https://github.com/bitwarden/clients/pull/7952

Beyond that, we'll take a look at resolving this when possible.