bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.09k stars 1.2k forks source link

Bitwarden Will Not Fill MileagePlus Information on United.com #8030

Closed iPeaches closed 7 months ago

iPeaches commented 7 months ago

Steps To Reproduce

  1. Access United.com and click the SIGN IN link at the top to open the pop-over log-in screen, or navigate to the full-page log-in screen at https://www.united.com/en/us/MyUnited
  2. Open Bitwarden Firefox Extension, unlock vault.
  3. Either click United login in the Extension's pop-over, or in the list under the MileagePlus Number field.

Expected Result

Bitwarden should fill the credentials, allowing for the user to select "Sign in" and access their United account.

Actual Result

The autofill animation plays, but the account information is not filled in to either box, either on the pop-over or the full-page screen. Both boxes are unable to accept keyboard input after attempting to autofill until the page is refreshed.

Screenshots or Videos

https://github.com/bitwarden/clients/assets/13423348/ccfcfee3-9681-4e8a-a8d0-0e5c8c753f88

Additional Context

Disabling UBlock Origin and Firefox Tracking Protection both do not resolve this problem. Following the instructions detailed in Issue #348 does not resolve this problem.

Operating System

Windows

Operating System Version

Version 10.0.22631 Build 22631

Web Browser

Firefox

Browser Version

122.0.1

Build Version

2024.2.0

Issue Tracking Info

Neonwarden commented 7 months ago

Hi there,

I attempted to reproduce your issue and was unable to do so. Please try clearing your browser's cache and cookies before reloading the page and attempting to use Bitwarden's in-line autofill again.

We use GitHub issues as a place to track bugs and other development related issues. If your issue persists, please write us back using our “Contact support” form located on our Help Center (https://bitwarden.com/help/).

You can include a link to this issue in the message content.

Alternatively, you can also search for an answer in our help documentation or get help from other Bitwarden users on our community forums (https://community.bitwarden.com/c/support/).

The issue here will be closed.

Thanks!

cagonzalezcs commented 7 months ago

As an extra note, this issue appears to be similar to another reported issue. - https://github.com/bitwarden/clients/issues/7837

Essentially, the way Firefox handles references to custom web elements is broken. Since the inline autofill menu uses custom web element to impede programmatic access, websites that attempt to pull attributes from the inline menu break in Firefox.

More info can be found in this comment.

As a workaround, I'd suggest the same thing that comment does:

For now, I'd recommend you use other means for autofilling the credentials on this website. It seems that either using the keyboard shortcut, context menu, or the popup to autofill works as expected. This is due to the fact that we do not inject any custom web components into the page, which avoids introducing the side effect behavior from the One Trust plugin.

iPeaches commented 7 months ago

Hi cagonzalezcs, I went ahead and followed your workaround, and this resolved the issue. Thank you!