search

bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.04k stars 1.19k forks source link

Add Login Notification cannot be dismissed with keyboard #855

Open Koolstr opened 5 years ago

Koolstr commented 5 years ago

The notification which shows for adding a new login to your vault cannot be dismissed by any means other than clicking the 'close' icon with your mouse.

Intuitively, and as it is in native browser add login notifications (Firefox, etc.), it should be able to be dismissed by pressing the Esc key on your keyboard. Essentially, the notification should act as a kind of overlay on top of the page, like a modal, that is acting as the top layer of interaction with the keyboard.

For people like me who try to navigate solely through the keyboard (with the help of keyboard shortcuts), small details in functionality like this are important.

This issue was experienced in Chrome, and is likely present in other browsers like Firefox as well. This issue likely exists for the Changed Password Notification too.

bitwarden-bot commented 2 years ago

Hi @Koolstr, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

Theraggon commented 4 weeks ago

I just tried this and I was able to tab to the close button. It's a lot of tabbing either back or forth as the element is at the end of the DOM but you can get there and then control it as per usual. Isn't this sufficient or is standard behavior for pop-ups like this different?

Tried on up to date Chromium based and Firefox base browser