Very slow to unlock or display UI + list of items when the self-hosted server is turned off

rchomat commented 5 months ago

Steps To Reproduce

Turn off the self-hosted server
On the browser app, unlock the safe. The app stays on the unlock screen for a while. Multi click on the unlock button doesn't change anything, it's stuck during several minutes. If you close the app and reopen it, the app is just a grey background without anything it in for several minutes

Expected Result

When a self-hosted server is disconnected, we should be able to use the local data without having to wait several minutes

Actual Result

UI & items are shown several minutes after the app is opened or the safe unlocked

Screenshots or Videos

No response

Additional Context

I use to turn on my server only when I need to synchronise my clients or save a new password. The rest of the time it's turned off.

Operating System

macOS

Operating System Version

14.4.1

Web Browser

Chrome

Browser Version

125.0.6422.142

Build Version

2024.5.2

Issue Tracking Info

[X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

maljac commented 5 months ago

I experience the same issue:

Operating System Windows 11 Pro

Operating System Version 22631.3737

Web Browser Chrome

Browser Version 125.0.6422.142

Build Version 2024.5.2

kevinarch commented 4 months ago

Same issue as well on macOS Edge:

Operating System
macOS

Operating System Version
14.2.1

Web Browser
Edge

Browser Version
125.0.2535.51 

Build Version
2024.6.1

PylotLight commented 4 months ago

Same issue

popy2k14 commented 3 months ago

Here are also infos of this issue: https://github.com/bitwarden/clients/issues/10128 ALso happens with the desktop app.

CirnoT commented 3 months ago

Can confirm this still exists and is particularly visible on unstable networks when HTTP requests end up getting timeout after ~15s which causes entire UI to be more or less unusable.

This annoys me so much that I have decided to attempt to dig as to reason for why this happens, and while I was unable to dig too deep without compiling extension myself, I can confirm that the issue started sometimes in 2024 (most likely between 2024.02 and 2024.05.1, so that's the range one should bisect) and that the following are my observations:

Extension will attempt to connect to provided identity server (usually identity.bitwarden.com/connect/token) to fetch new token based on stored refresh token
The source of request is unknown, stack trace ends at abstract-chrome-storage-api.service.ts, however that request is routed via zone-ified Promise in order to retrieve value of user_{}_token_refreshToken which then gets used in actual request.
Whoever is owner of this request explicitly wants request to happen synchronically and locks entire extension awaiting result from it
The request is fired from api.service.ts::nativeFetch which calls zone-ified fetch providing standard browser Fetch API. Nowhere in this stack anything sets any timeout, so the TCP timeout for this HTTP request is entirely up to networking stack of browser and OS
Replication is iffy at best; the extension seems to cache token for some time, so unlocking vault while networking is up and then locking it and replicating network fault condition will not trigger described issue as extension won't send request that causes it. Note that token seems to be cached even after browser restart; replication is possible again only after token expires.

gdzevo commented 3 months ago

Same here, on a desktop app as well as with extension. Offline mode is completely broken, the only workaround is to route *.bitwarden.com to 127.0.0.1

tombogle commented 3 months ago

I'm not sure this is just a self-hosted issue. I've been getting it intermittently for the past couple months. Haven't paid careful attention, but now I'm thinking that maybe it only happens at work, so maybe it is environment/network related. I've found that if I disable the extension and then immediately re-enable it, the problem goes away (for a while).

CirnoT commented 3 months ago

I'm not sure this is just a self-hosted issue.

It's not, in my example above I have been testing it by emulating severe packet loss to Bitwarden's cloud endpoints. It can certainly be more visible in self-hosted environments as chance for some connectivity issue there is higher. On the other hand, should some global outage happen to Bitwarden's cloud instances then we would also observe swarm of people reporting this issue (not everyone though, at least those that unlocked extension in past 24h should be fine).

MatthiasGer0821 commented 3 months ago

same here.

popy2k14 commented 3 months ago

@NovaSilentium Any news on this. Currently both (Browser Extension and Desktop Client (Windows in my case) are literally unusable for about ~30secs when self hosted server is not reachable.

rchomat commented 2 months ago

@justindbaur I've updated the plugin on chrome with the 2024.8.1 and the issue is still the same. Could you please reopen this issue and please take a look at the comment I wrote on your PR: https://github.com/bitwarden/clients/pull/10452#issuecomment-2303051315

Please, push a fix ASAP, This bug has been present for months and is very annoying.

rchomat commented 2 months ago

cc @trmartin4

gdzevo commented 2 months ago

same on firefox, issue is still present

popy2k14 commented 2 months ago

issue is also still here on brave (chromium) browser and desktop client with latest 2024.8.1

djsmith85 commented 2 months ago

The changes merged by @justindbaur have not been included in a release yet. They will be included in a following release.

jason84019020 commented 2 months ago

The problem with the Chrome extension in version 2024.8.1 still persists. Despite the recent update, the issue has not been resolved.

popy2k14 commented 2 months ago

@jason84019020 As @djsmith85 stated, the fix has not been released yet.

I hope it will be soon.

MitosisByProxy commented 2 months ago

Issue still persists as of version 2024.8.1 for firefox. Is there any indication in which version this will be included?

davidsu-citylitics commented 2 months ago

painfully painfully slow and unusable for Version: 2024.8.1

popy2k14 commented 2 months ago

Yes, it's really unusable :-(

Please release this fix!!!!

rchomat commented 2 months ago

@justindbaur is it possible to release your fix as a hotfix ASAP ? The bug completely breaks the app since several month now ! That's unusable unless you wait several minutes to get access to your vault !

cyberfox1 commented 2 months ago

The changes merged by @justindbaur have not been included in a release yet. They will be included in a following release.

How could this not be fixed already???

andysmile1 commented 2 months ago

Same here. iOS app cannot load vault for around 60 seconds if the self-hosted server is offline. The only way to load the vault instantly offline is that to turn my phone into airplane mode.

p-rintz commented 2 months ago

So, it seems kind of fixed in 2024.9.0. This is for the Chrome extension. I wasnt able to test the desktop client or Firefox extension yet.

When unlocking while not connected to the Bitwarden instance, you can access the vault immediately afterwards. But not until closing the window and reopening the extension. If you input your password to unlock the vault, without a connection to the instance, the password input screen stays frozen for 30-60 seconds and does not transition to the vault, like it does when connected to the instance.

You can see this here. The vault is open (as shown with the 9+ in the BW icon), but the password screen stays.

rchomat commented 2 months ago

@justindbaur @trmartin4

I've tried on chrome with the extension updated to the 2024.9.0 version and the behaviour is still the same issue. While trying to unlock the vault or when already unlocked and trying to access to it.

Please reopen this issue and do a HF ASAP in order we don't need to wait 3 other months with this very annoying bug

please take a look at my comment https://github.com/bitwarden/clients/pull/10452#issuecomment-2303051315

that's when it's trying to do a refresh token in api.service.ts::refreshAccessToken()

Screenshot 2024-09-12 at 09 51 17

popy2k14 commented 2 months ago

Issue also not solved for me on newest brave (chromium based). When accessing the vault with the extension it just shows nothing for about 1 minute:

Please reopen the issue @DigitallyRefined @justindbaur @trmartin4

neeqkowlah commented 2 months ago

not solved for me with Version 2024.9.0 and Chrome Version 128.0.6613.119 (Build officiel) (64 bits) ;-)

justindbaur commented 2 months ago

2024.9.0 did not include the fix, it was itself a hotfix, we have a release coming up pretty soon that will include the fix.

I can see the /connect/token calls taking awhile but those should largely be being done in the background and much more rarely. It's also code that hasn't changed in quite a while and we haven't previously had issues with it in this way, but a more recent change is having a feature flag to decide whether or not to show our upcoming UI refresh, that happens loads of times throughout the app and any delays there can have a noticable impact.

rchomat commented 2 months ago

@justindbaur why isn't it already pushed as a HF ? That's really boring and we're facing this issue since more than three months now.

justindbaur commented 2 months ago

@rchomat We have pretty strict rules around what makes something hotfix-worthy and about what can be included. This doesn't meet the standards we have.

rchomat commented 2 months ago

@justindbaur seems weird to me that something breaking a basic usage of the app is not considered as candidate for a HF but ok. When can we expect to see that fix deployed in order we don't bother you at each version ?

rchomat commented 2 months ago

@justindbaur I've just built in local what's on main branch and added the extension in my browser to see if it will be better once your fix is deployed. It's indeed way better but still having 5-10 seconds of blank screen. Thanks for this improvement. Can we improve that even more ? Do we need to get feature flags every time we need open the app. Can't it be called sometimes as a background task in order it doesn't bother the user?

MelHiour commented 1 month ago

It's time to find some alternatives, I am afraid...

victornavorskie commented 1 month ago

same problem here, i have been using Bitwarden since 4 years and since 3 months is unusable and still no fix i think i will find something else

kleinarne commented 1 month ago

I'm not going to try and throw my weight around and declare this a reason to leave Bitwarden. But I do agree that this is an extremely frustrating issue, because it happens multiple times before I can even access the first passwords (on submitting my main password, then on accessing the credentials list). I have been waiting very impatiently for the 2024.9.0 update, and seeing that the fix hasn't made it to that update is incomprehensible to me, as it is for a number of others.

Self-hosters and people behind restrictive corporate firewalls may not be the majority of users, but maybe keep in mind that technologically savvy users tend to be loyal multiplicators for you as long as you don't antagonise them. Frankly, having to wait another three months without any comment on ETA feels like an undeserved level of communication for those who self-host, report bugs, and advocate Bitwarden to those around them.

rchomat commented 1 month ago

If you still want to use bitwarden without having this issue, you can downgrade to the 2024.4.2 (I haven't tried a more recent version). I'm using it for the moment and it works properly (be careful with the manifest.json, it's in v2 and chrome is going to disable this version, maybe try with the 2024.5.0 with seems using the v3 of manifest.json and not having this issue?)

victornavorskie commented 1 month ago

@kleinarne Sure, but for me it is really a problem, all my private passwords and work are in bitwarden and every day at work I have to contact in different services with sso and every time I have to connect to home with VPN to activate the bitwarden client. First I will install the @rchomat version if it works great, if not then maybe I will use keepass local for work until this issue is solved.

popy2k14 commented 1 month ago

@justindbaur any news on this when we finally get a fixed client?

rchomat commented 1 month ago

Seems like the 2024.9.1 finally contains the fix but we need to wait several seconds every time we open the app or when you click on a tab (vault, send, generator, ...) when you want to access an item in your vault, ... Better but still a painful usage... @justindbaur could you please, find some time to improve that ?

p-rintz commented 1 month ago

Seems like the 2024.9.1 finally contains the fix but we need to wait several seconds every time we open the app or when you click on a tab (vault, send, generator, ...) when you want to access an item in your vault, ... Better but still a painful usage... @justindbaur could you please, find some time to improve that ?

Cant confirm on Firefox. Same issue as before. Its the same as with 2024.9.0 where the vault unlocks, but the UI doesnt update until a while later or if you click out of the window and reopen Bitwarden. (as explained here: https://github.com/bitwarden/clients/issues/9561#issuecomment-2345512071 )

Though I can confirm your secondary issue, where switching between tabs takes roughly 2 seconds.

trmartin4 commented 1 month ago

We are continuing to work on this issue and have some additional improvements in progress to make this experience better. Thank you very much for your patience and for the feedback on exactly how the issue is occurring.

rchomat commented 1 month ago

Seems like the 2024.9.1 finally contains the fix but we need to wait several seconds every time we open the app or when you click on a tab (vault, send, generator, ...) when you want to access an item in your vault, ... Better but still a painful usage... @justindbaur could you please, find some time to improve that ?

Cant confirm on Firefox. Same issue as before. Its the same as with 2024.9.0 where the vault unlocks, but the UI doesnt update until a while later or if you click out of the window and reopen Bitwarden. (as explained here: #9561 (comment) )

Though I can confirm your secondary issue, where switching between tabs takes roughly 2 seconds.

@p-rintz The unlock form where the master password is required is indeed still slow as before but if you close the UI and reopen it, it's then faster (still need to wait several seconds but better) At least on chrome with the 2024.10.0

Thanks @trmartin4. Hope we won't have to wait again several months before seeing those improvements

bitwarden / clients