[PM-7972] Account switching integration with "remember email" functionality

jlf0dev commented 1 week ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7972

📔 Objective

"Remember email" feature on login page didn't have great integration with account switching. This adds the following functionality.

If adding an account through account switching:

Don't show the remembered email
Never clear the remembered email if box isn't checked (original email should persist)
Overwrite the remembered email if box is checked
📸 Screenshots

https://github.com/bitwarden/clients/assets/24985544/0a1b86fe-546d-4b2d-a4c3-b17d49e94fc0

https://github.com/bitwarden/clients/assets/24985544/7c1a2a8b-f8a1-44d4-bcac-9f124979483f

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.16%. Comparing base (8d04731) to head (d947fc9). Report is 6 commits behind head on main.

Files	Patch %	Lines
...sktop/src/app/layout/account-switcher.component.ts	0.00%	1 Missing :warning:
...ibs/angular/src/auth/components/login.component.ts	0.00%	1 Missing :warning:
...common/services/login-email/login-email.service.ts	96.42%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9750 +/- ## ========================================== + Coverage 28.84% 29.16% +0.32% ========================================== Files 2510 2531 +21 Lines 73346 73728 +382 Branches 13704 13759 +55 ========================================== + Hits 21153 21502 +349 - Misses 50578 50609 +31 - Partials 1615 1617 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Checkmarx One – Scan Summary & Details – 6b0c013a-9eda-4ff7-a2c5-58d8fb218cba

bitwarden / clients