PM-4661: Add passkey.username as item.username

abergs commented 3 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-4661

📔 Objective

📸 Screenshots

https://share.cleanshot.com/p1PH1krC

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.53%. Comparing base (1763324) to head (60da604). Report is 62 commits behind head on main.

Files	Patch %	Lines
...rc/vault/popup/components/fido2/fido2.component.ts	0.00%	3 Missing :warning:
...vault/popup/components/vault/add-edit.component.ts	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9756 +/- ## ========================================== + Coverage 29.29% 29.53% +0.23% ========================================== Files 2532 2538 +6 Lines 73789 74143 +354 Branches 13770 13853 +83 ========================================== + Hits 21620 21895 +275 - Misses 50547 50587 +40 - Partials 1622 1661 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Checkmarx One – Scan Summary & Details – 8fb03e1f-5777-4060-b156-45f6bb6a6d43

New Issues

Issue	Source File / Package	Checkmarx Insight
Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2	Attack Vector
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1256	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1210	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-cli.yml: 406	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Client_DOM_Open_Redirect	/apps/browser/src/platform/popup/layout/popup-header.component.ts: 29	Attack Vector
Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2	Attack Vector
Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2	Attack Vector
Client_Use_Of_Iframe_Without_Sandbox	/apps/web/src/connectors/duo.ts: 8	Attack Vector
Unprotected_Cookie	/apps/web/src/app/auth/two-factor.component.ts: 159	Attack Vector
Unprotected_Cookie	/apps/web/src/connectors/duo-redirect.ts: 57	Attack Vector
Unprotected_Cookie	/apps/web/src/connectors/duo-redirect.ts: 112	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 402
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1222
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1268
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Unsafe_Use_Of_Target_blank	/apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 45
	Unsafe_Use_Of_Target_blank	/apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 58

abergs commented 3 months ago

@kendratodd Perhaps you could help me test this unless it lands well into existing QA processes?

kendratodd commented 3 months ago

@abergs, I'm always happy to take a look, though I do believe this can be covered by existing QA processes for the Vault team (the JIRA just needs to be updated to reflect the current status).

abergs commented 3 months ago

Let's see if I managed to fix the tests and actually run them now ...

bitwarden / clients