[PM-8381] Assign collections

nick-livefront commented 3 months ago

Stacked on top of @gbubemismith's https://github.com/bitwarden/clients/pull/9507

🎟️ Tracking

📔 Objective

Add "Assign Collections" screen
Moving a cipher into an organization and assigned to at least one collection
Reassigning collections within an organization
The select & multi-select that are shown in the designs do not appear to be available yet.

📸 Screenshots

Move cipher to org	reassign collections

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 28.79%. Comparing base (e844e7a) to head (5573993). Report is 63 commits behind head on vault/PM-7625.

:exclamation: Current head 5573993 differs from pull request most recent head 685e368

Please upload reports for the commit 685e368 to get more accurate results.

Files	Patch %	Lines
...assign-collections/assign-collections.component.ts	0.00%	29 Missing :warning:
apps/browser/src/popup/app-routing.module.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## vault/PM-7625 #9757 +/- ## ================================================= - Coverage 28.79% 28.79% -0.01% ================================================= Files 2512 2513 +1 Lines 73545 73575 +30 Branches 13763 13767 +4 ================================================= + Hits 21177 21184 +7 - Misses 50745 50768 +23 Partials 1623 1623 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Checkmarx One – Scan Summary & Details – 198cb77b-3e90-4997-ba52-6672c81fbd3a

No New Or Fixed Issues Found

shane-melton commented 3 months ago

@nick-livefront Gbubemi's branch has had a handful of changes recently, can we pull those in?

nick-livefront commented 3 months ago

Oh, I botched that merge from @gbubemismith branch. I'm going to close this PR and open a new one once I get the git straightened out.

bitwarden / clients