quexten commented 1 week ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7084 https://bitwarden.atlassian.net/browse/PM-9098

📔 Objective

This PR adds the shared two-factor-options-component but does not make use of it yet. QA testing for this PR will be done with the follow-up #9768, and the 2 will be merged at the same time.

[!IMPORTANT]
STACKED PR: This set of changes is split into a set of smaller PR's that can be reviewed independently, in parallel. Merging still should be done in order once all PR's are reviewed. Merging can be done incrementally as the feature is feature flagged.

9767 - Shared two-fa options component

9768 - Shared two-fa orchestrator component & totp authenticator component

9769 - Shared two-fa yubikey component

9770 - Shared two-fa email component

9771 - Shared two-fa webauthn component

9772 - Shared two-fa duo component

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (93a57e6) to head (36e3d10).

Files	Patch %	Lines
...ts/two-factor-auth/two-factor-options.component.ts	0.00%	34 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9767 +/- ## ========================================== - Coverage 29.33% 29.31% -0.02% ========================================== Files 2528 2529 +1 Lines 73768 73802 +34 Branches 13772 13776 +4 ========================================== Hits 21637 21637 - Misses 50509 50543 +34 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Checkmarx One – Scan Summary & Details – fdfb763c-d06f-46ef-8b9a-0cfd0fff3653

bitwarden / clients

[PM-7084] 1/6: Add shared two-factor-options component #9767