bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

Include sources in scan workflow for Sonar #9789

Closed bwdil closed 1 week ago

bwdil commented 1 week ago

🎟️ Tracking

PM-7288: Deploy scanning workflow organization-wide

📔 Objective

Improving code quality and code coverage issues with Sonar

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.29%. Comparing base (705a020) to head (6de0819).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9789 +/- ## ========================================== - Coverage 29.30% 29.29% -0.01% ========================================== Files 2532 2532 Lines 73785 73785 Branches 13770 13770 ========================================== - Hits 21620 21613 -7 - Misses 50543 50550 +7 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Detailsa7b647b8-2956-4c51-8f33-3b5436a7d141

No New Or Fixed Issues Found

withinfocus commented 1 week ago

@urbinaalex17 we will always scan the entire repo every time we roll out Sonar, with the caveat being identifying the correct source paths that are relevant. I am not sure this repo needs a tweak given its layout.