bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

SM-1146: Display total counts of projects, machine accounts, secrets in Secrets Manager #9791

Open mzieniukbw opened 1 week ago

mzieniukbw commented 1 week ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/SM-1146

📔 Objective

Display total counts of projects, machine accounts, secrets in Secrets Manager:

Notes

📸 Screenshots

Navigation and Organization overview:

image

Project details

image

Machine account details

image

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 8.42105% with 87 lines in your changes missing coverage. Please review.

Project coverage is 29.29%. Comparing base (2a0e21b) to head (c725d53). Report is 66 commits behind head on main.

Files Patch % Lines
...app/secrets-manager/layout/navigation.component.ts 0.00% 21 Missing :warning:
...er/shared/access-policies/access-policy.service.ts 12.50% 14 Missing :warning:
...rets-manager/projects/project/project.component.ts 0.00% 10 Missing :warning:
...ager/service-accounts/service-account.component.ts 0.00% 9 Missing :warning:
...src/app/secrets-manager/secrets-manager.service.ts 0.00% 7 Missing :warning:
...ecrets-manager/models/responses/counts.response.ts 0.00% 6 Missing :warning:
...app/secrets-manager/overview/overview.component.ts 0.00% 6 Missing :warning:
...nager/projects/models/responses/counts.response.ts 33.33% 4 Missing :warning:
...rvice-accounts/models/responses/counts.response.ts 33.33% 4 Missing :warning:
...rc/app/secrets-manager/projects/project.service.ts 33.33% 2 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9791 +/- ## ========================================== + Coverage 28.85% 29.29% +0.44% ========================================== Files 2511 2532 +21 Lines 73277 73847 +570 Branches 13675 13783 +108 ========================================== + Hits 21146 21637 +491 - Misses 50521 50588 +67 - Partials 1610 1622 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Logo Checkmarx One – Scan Summary & Details – d92d86d7-4143-42dd-a49b-97daa0012a5d

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: 2 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/platform/popup/layout/popup-header.component.ts: 29 Attack Vector
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2 Attack Vector
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2 Attack Vector
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/web/src/connectors/duo.ts: 8 Attack Vector
LOW Unprotected_Cookie /apps/web/src/app/auth/two-factor.component.ts: 159 Attack Vector
LOW Unprotected_Cookie /apps/web/src/connectors/duo-redirect.ts: 57 Attack Vector
LOW Unprotected_Cookie /apps/web/src/connectors/duo-redirect.ts: 112 Attack Vector

Fixed Issues

Severity Issue Source File / Package
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2