bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.66k stars 1.14k forks source link

Brave: Log in with passkey -> Verify with biometrics errors if browser extension is already unlocked #9795

Open ethansaxenian opened 1 week ago

ethansaxenian commented 1 week ago

Steps To Reproduce

  1. Ensure the browser extension is already unlocked
  2. Attempt to log into a website (e.g. https://community.bitwarden.com) with a passkey
  3. Click the Confirm button on the Log in with passkey? popup

Expected Result

I expect to be logged into the website via my saved passkey.

Actual Result

The popup displays an error: Could not complete biometrics.

Screenshots or Videos

screenshot

Additional Context

I can confirm that the Use master password option works as expected.

This error seemingly only occurs if the browser extension is already unlocked when I attempt to log in. If the extension is locked, I am prompted to unlock the vault using biometrics (which succeeds) before the Log in with passkey? popup is shown. Once I click Confirm I am logged in as expected.

Operating System

macOS

Operating System Version

Sonoma 14.3.1

Web Browser

Brave

Browser Version

1.67.119

Build Version

2024.6.2

Issue Tracking Info

githubzhuanyong commented 1 week ago

I also encountered the same problem, using the passkey to log in. When verifying, if the browser extension has been unlocked, it prompts "Unable to complete biometrics". Error, please try again. At the same time, I confirm that using the master password to verify is OK, but if the browser extension is not unlocked, it can invoke the bitwarden desktop to complete the biometric verification.

Operating System Version:Windows 10 Version 22H2 Browser Version : Google Chrome 126.0.6478.115 Build Version :2024.6.2 PixPin_2024-06-24_14-32-53

gokussjx commented 6 days ago

Same issue on both Firefox and Brave on macOS. Surprisingly, Safari is fine, likely due to the extension being an older one?

SergeantConfused commented 6 days ago

Hello @ethansaxenian and everyone else,

Thank you all for your input. I was able to reproduce this behaviour and have flagged it to the Engineering department. Please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

This was reproduced with Bitwarden browser extension 2024.6.2 in Chrome 126.0 and Brave 1.67.119 on macOS 14.5, but Firefox 127.0.1 and Safari 17.5 worked as expected; On Windows 11 Pro 23H2, this was reproduced in Chrome 126.0 and Brave 1.67.119, but Firefox 127.0 and Edge 126.0 worked as expected.

@gokussjx, could you please check what version of Bitwarden browser extension and Firefox you're using? I was able to use Touch ID in order to use a passkey from my Bitwarden vault in testing within Firefox.

Thank you all again,

just5ky commented 6 days ago

Looks to be related to these PRs

https://github.com/bitwarden/clients/pull/8746 https://github.com/bitwarden/clients/pull/9734

Windows

Browser: Brave Version 1.67.119 Chromium: 126.0.6478.114 (Official Build) (64-bit) Extension version: 2024.6.2 image

Desktop App version: image

MacOS

Browser: Brave Version 1.67.119 Chromium: 126.0.6478.114 (Official Build) (arm64) Extension version: 2024.6.2 Desktop App version:


User Verification: Discouraged

Recording 2024-06-22 at 21 55 40

User Verification: Preferred

Recording 2024-06-22 at 21 57 19

gokussjx commented 3 days ago

@SergeantConfused I'll amend my statement. I think I saw it occur a few times in Firefox, but can't reproduce it any more, hence, Brave is the only one having issues.

just5ky commented 3 days ago

@SergeantConfused I'll amend my statement. I think I saw it occur a few times in Firefox, but can't reproduce it any more, hence, Brave is the only one having issues.

It seems to be to only happening on Chrome Web Store version of the extension

TLDR: works fine in Firefox, Edge with edge web store extension instead of Chrome web store.

Here's the test that I conducted:

OS

Desktop App

image

Tested on webauthn.io with User Verification : Preferred

Browsers