bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

Add eslint rule prohibiting Bitwarden-licensed imports in OSS code #9801

Closed eliykat closed 3 days ago

eliykat commented 5 days ago

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

Add an eslint rule prohibiting importing Bitwarden-licensed code in OSS code.

This uses the no-restricted-imports for regular static import statements, and no-restricted-syntax for dynamic imports per this recommendation.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

๐Ÿฆฎ Reviewer guidelines

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.30%. Comparing base (ffb99ef) to head (bef8de7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9801 +/- ## ======================================= Coverage 29.29% 29.30% ======================================= Files 2532 2532 Lines 73785 73785 Branches 13770 13770 ======================================= + Hits 21613 21620 +7 + Misses 50550 50543 -7 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

Logo Checkmarx One โ€“ Scan Summary & Details โ€“ 9f60a374-2eb8-4217-a433-badf30713227

No New Or Fixed Issues Found