[PM-8718] Streamlined SSO autosubmit flow

quexten commented 5 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/87?selectedIssue=PM-8718

📔 Objective

If the identifier parameter is passed in the URL, the component will auto-submit the form and redirect to login if the sso identifier does not exist, and to the sso provider if it does exist.

Concerns for reviewing: :question: Right now we just catch all errors from the parent component, the sso prevalidation failing being one of them. Are there other errors, where redirecting to /login after the autosubmit flow failed is a problem?

📸 Screenshots

(Recording is in the Jira ticket)

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.29%. Comparing base (ffb99ef) to head (1189cfa).

Files	Patch %	Lines
apps/web/src/app/auth/sso.component.ts	12.50%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9803 +/- ## ========================================== - Coverage 29.29% 29.29% -0.01% ========================================== Files 2532 2532 Lines 73785 73792 +7 Branches 13770 13771 +1 ========================================== + Hits 21613 21614 +1 - Misses 50550 50556 +6 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

Checkmarx One – Scan Summary & Details – 36c2eec9-2cc4-4aec-9025-8f2be216772f

bitwarden / clients