bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

[PM-7330] Create SetPasswordComponent (email verification) #9810

Open rr-bw opened 4 days ago

rr-bw commented 4 days ago

🎟️ Tracking

📔 Objective

Creates a base SetPasswordV2Component class file in Libs, and a Web SetPasswordV2Component, which is routed to when the email verification feature flag is on.

Much of the logic for the V2 component is copied from our existing SetPasswordComponent and then modified to work with our new InputPasswordComponent.

📸 Screenshots

https://github.com/bitwarden/clients/assets/102181210/1bc091af-16a8-4484-8a39-4a17f11143b3

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0.71429% with 139 lines in your changes missing coverage. Please review.

Project coverage is 29.40%. Comparing base (c01f6be) to head (8f12bfa).

Files Patch % Lines
...r/src/auth/components/set-password-v2.component.ts 0.00% 109 Missing :warning:
apps/web/src/app/auth/set-password-v2.component.ts 0.00% 13 Missing :warning:
libs/angular/src/auth/guards/auth.guard.ts 0.00% 6 Missing :warning:
...angular/input-password/input-password.component.ts 0.00% 6 Missing :warning:
libs/angular/src/auth/components/sso.component.ts 25.00% 3 Missing :warning:
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing :warning:
libs/auth/src/angular/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9810 +/- ## ========================================== - Coverage 29.46% 29.40% -0.06% ========================================== Files 2537 2539 +2 Lines 74045 74180 +135 Branches 13827 13853 +26 ========================================== + Hits 21814 21815 +1 - Misses 50579 50713 +134 Partials 1652 1652 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

Logo Checkmarx One – Scan Summary & Details783b299d-c140-49c5-8a53-62640727b057

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /bitwarden_license/bit-web/src/app/admin-console/providers/providers-layout.component.html: 49 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/settings/two-factor-duo.component.html: 15 Attack Vector
MEDIUM Client_Privacy_Violation /libs/auth/src/angular/input-password/input-password.component.html: 14 Attack Vector
MEDIUM Client_Privacy_Violation /libs/auth/src/angular/input-password/input-password.component.html: 44 Attack Vector