Open rr-bw opened 4 days ago
Attention: Patch coverage is 0.71429%
with 139 lines
in your changes missing coverage. Please review.
Project coverage is 29.40%. Comparing base (
c01f6be
) to head (8f12bfa
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 783b299d-c140-49c5-8a53-62640727b057
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Angular_Improper_Type_Pipe_Usage | /bitwarden_license/bit-web/src/app/admin-console/providers/providers-layout.component.html: 49 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/auth/settings/two-factor-duo.component.html: 15 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/auth/src/angular/input-password/input-password.component.html: 14 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/auth/src/angular/input-password/input-password.component.html: 44 | Attack Vector |
🎟️ Tracking
📔 Objective
Creates a base
SetPasswordV2Component
class file in Libs, and a WebSetPasswordV2Component
, which is routed to when the email verification feature flag is on.Much of the logic for the V2 component is copied from our existing SetPasswordComponent and then modified to work with our new
InputPasswordComponent
.📸 Screenshots
https://github.com/bitwarden/clients/assets/102181210/1bc091af-16a8-4484-8a39-4a17f11143b3
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes