Closed audreyality closed 1 day ago
âģī¸ Sometimes I need to learn things the hard way.
Attention: Patch coverage is 26.19048%
with 31 lines
in your changes missing coverage. Please review.
Project coverage is 29.31%. Comparing base (
1495b06
) to head (13b82cd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â 80430dc8-895a-419f-a48f-ab32d5ddc84a
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1222 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1268 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Severity | Issue | Source File / Package |
---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1256 |
![]() |
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1210 |
đ Merged main
to fix the macOS build errors.
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-9170
đ Objective
Combines the following PRs to avoid DI failures due to misalignment between angular libraries and consuming apps:
9669
9666
9662
9638
9637
Note: All of the above PRs have already been reviewed. This PR just smashes them all together on the latest code from
main
, fixes the resulting conflicts, and reverts the factory rename in the CLI.đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes