bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

[PM-9170] combine library migrations #9812

Closed audreyality closed 1 day ago

audreyality commented 4 days ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-9170

📔 Objective

Combines the following PRs to avoid DI failures due to misalignment between angular libraries and consuming apps:

Note: All of the above PRs have already been reviewed. This PR just smashes them all together on the latest code from main, fixes the resulting conflicts, and reverts the factory rename in the CLI.

đŸĻŽ Reviewer guidelines

audreyality commented 4 days ago

â™ģī¸ Sometimes I need to learn things the hard way.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (1495b06) to head (13b82cd).

Files Patch % Lines
.../tools/generator/components/generator.component.ts 0.00% 2 Missing :warning:
...src/auth/popup/login-via-auth-request.component.ts 0.00% 1 Missing :warning:
apps/browser/src/auth/popup/login.component.ts 0.00% 1 Missing :warning:
apps/browser/src/auth/popup/register.component.ts 0.00% 1 Missing :warning:
apps/browser/src/auth/popup/sso.component.ts 0.00% 1 Missing :warning:
apps/browser/src/background/main.background.ts 0.00% 1 Missing :warning:
...r/src/tools/popup/generator/generator.component.ts 0.00% 1 Missing :warning:
.../generator/password-generator-history.component.ts 0.00% 1 Missing :warning:
apps/desktop/src/app/app.component.ts 0.00% 1 Missing :warning:
apps/desktop/src/app/services/services.module.ts 0.00% 1 Missing :warning:
... and 20 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9812 +/- ## ========================================== - Coverage 29.32% 29.31% -0.01% ========================================== Files 2527 2526 -1 Lines 73783 73776 -7 Branches 13778 13778 ========================================== - Hits 21637 21628 -9 - Misses 50524 50526 +2 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

Logo Checkmarx One – Scan Summary & Details – 80430dc8-895a-419f-a48f-ab32d5ddc84a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1222 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1268 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1256
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1210
audreyality commented 2 days ago

📝 Merged main to fix the macOS build errors.