[AC-2795] Combine provider subscription and payment method pages

amorask-bitwarden commented 3 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2795

📔 Objective

This PR removes the Payment Method page from the Provider Portal, but adds the Account Credit and Tax Information components that used to be on that page to the Subscription page instead. The only component being permanently removed is the Payment Method component. It also refactors the subscription-status.component to be provider-specific since it has a dependency on the ProviderSubscriptionResponse.

📸 Screenshots

Screenshot 2024-06-25 at 1 36 18 PM

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 29.30%. Comparing base (c35bbc5) to head (1f9048e).

Files	Patch %	Lines
...rs/subscription/provider-subscription.component.ts	0.00%	16 Missing :warning:
.../models/response/provider-subscription-response.ts	0.00%	13 Missing :warning:
...odels/response/subscription-suspension.response.ts	0.00%	6 Missing :warning:
...cription/provider-subscription-status.component.ts	0.00%	3 Missing :warning:
...rc/app/admin-console/providers/providers.module.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9828 +/- ## ========================================== - Coverage 29.32% 29.30% -0.02% ========================================== Files 2528 2529 +1 Lines 73788 73806 +18 Branches 13771 13776 +5 ========================================== - Hits 21639 21632 -7 - Misses 50527 50552 +25 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Checkmarx One – Scan Summary & Details – c4183701-c91e-47a2-8cfe-6dac21af2991

bitwarden / clients