Closed willmartian closed 3 days ago
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 29.33%. Comparing base (
9ec0142
) to head (eb4f1ae
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – a5e98bc2-2e4d-4d2f-8305-66fc9fac824b
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Client_Use_Of_Iframe_Without_Sandbox | /apps/web/src/connectors/duo.ts: 8 | Attack Vector |
Severity | Issue | Source File / Package |
---|---|---|
![]() |
Client_DOM_Open_Redirect | /apps/browser/src/platform/popup/layout/popup-header.component.ts: 29 |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-319
📔 Objective
Add the ability to customize the back action in the popup header component.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes