[AC-2803] Make provider discount dynamic in provider portal for Consolidated Billing

amorask-bitwarden commented 3 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2803

📔 Objective

Updates the Provider Portal to dynamically display or hide the UI elements related to a provider's subscription discount based on whether one exists or not. Previously, some of this was hard-coded as we always expected the guaranteed 35% discount.

📸 Screenshots

https://github.com/bitwarden/clients/assets/144709477/55895b34-480d-4000-8326-0fa5e84d44e1

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (679c25b) to head (97f3ae7).

Files	Patch %	Lines
...roviders/clients/create-client-dialog.component.ts	0.00%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9831 +/- ## ========================================== - Coverage 29.31% 29.31% -0.01% ========================================== Files 2529 2529 Lines 73786 73788 +2 Branches 13777 13778 +1 ========================================== Hits 21630 21630 - Misses 50534 50536 +2 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Checkmarx One – Scan Summary & Details – ce68d091-729a-471e-b410-a1b1a673761a

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/bitwarden_license/bit-web/src/app/admin-console/providers/providers-layout.component.html: 49	Attack Vector

bitwarden / clients