Add setuptools to mac pipeline

MGibson1 commented 3 days ago

📔 Objective

Fixes missed mac os build runners from #8073.

Mac runners have progressed above python 3.12, which removed distutils. We need to ensure it's installed for node-gyp compilations by installing the setuptools package.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.31%. Comparing base (c35bbc5) to head (aa614c3). Report is 11 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9834 +/- ## ========================================== - Coverage 29.32% 29.31% -0.02% ========================================== Files 2528 2529 +1 Lines 73788 73787 -1 Branches 13771 13778 +7 ========================================== - Hits 21639 21630 -9 - Misses 50527 50535 +8 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Checkmarx One – Scan Summary & Details – dab37d9e-b265-400b-94bc-f395fc8bde22

New Issues

Issue	Source File / Package	Checkmarx Insight
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1222	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1268	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Client_DOM_Open_Redirect	/apps/browser/src/platform/popup/layout/popup-header.component.ts: 29	Attack Vector
Client_Use_Of_Iframe_Without_Sandbox	/apps/web/src/connectors/duo.ts: 8	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1256
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1210

dani-garcia commented 3 days ago

Nice, I noticed the build failures and was about to open a PR when I saw you were quicker hah.

We're still missing setuptools in the MacOS Package Dev Release Asset job, but otherwise LGTM

bitwarden / clients