bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

PM-4878: Add passkey information to items when signing in #9835

Open abergs opened 3 days ago

abergs commented 3 days ago

šŸŽŸļø Tracking

https://bitwarden.atlassian.net/browse/PM-4878

šŸ“” Objective

šŸ“ø Screenshots

CleanShot 2024-06-26 at 01 00 39@2x

ā° Reminders before review

šŸ¦® Reviewer guidelines

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.52%. Comparing base (8df054c) to head (2ea2ac9). Report is 26 commits behind head on main.

Files Patch % Lines
...pup/components/fido2/fido2-cipher-row.component.ts 0.00% 6 Missing :warning:
libs/common/src/vault/models/view/login.view.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9835 +/- ## ========================================== + Coverage 29.32% 29.52% +0.20% ========================================== Files 2528 2538 +10 Lines 73767 74144 +377 Branches 13771 13854 +83 ========================================== + Hits 21630 21889 +259 - Misses 50515 50595 +80 - Partials 1622 1660 +38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Logo Checkmarx One ā€“ Scan Summary & Details ā€“ f455966b-4398-4640-bc46-434792796720

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1210 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1256 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 406 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 402
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1222
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1268
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 45
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/auth/settings/two-factor-authenticator.component.html: 58