"Never" timeout warning stuck in infinite loop

[bwbug]

Steps To Reproduce

1. Go to Settings > Account Security.
2. Set Vault Timeout period to "Never", and click Yes on modal pop-up with "Are you sure" warning.
3. Click < Back, or close browser extension window.
4. Go to Settings > Account Security.
5. Click No.

Expected Result

• At Step ♯4, expect the Account Security settings to be displayed (showing the value "Never" for the Vault Timeout), with no modal pop-up warning.
• At Step ♯5, expect the modal pop-up warning to close, and the value of the Vault Timeout period to revert to the most recent value that was not "Never", or revert to the default value.

Actual Result

• At Step ♯4, the modal pop-up warning ("Are you sure") is displayed as soon as the Account Settings page is opened (without user interaction), as shown in the screenshot below.

• At Step ♯5, the modal pop-up warning briefly closes when clicking No, but then immediately re-opens; the same thing happens if clicking outside the modal pop-up, or if pressing the Esc key. There is an infinite loop, which can only be broken by clicking Yes.

Screenshots or Videos

Additional Context

The modal pop-up with the "Are you sure" warning should only be displayed if the user has just changed the Vault Timeout value from a value other than "Never" to a new value of "Never". If the value has previously been set to "Never", then the warning should not be displayed when opening the Account Security page.

If developers deem it essential for users to re-affirm their choice to use a Vault Timeout of "Never" each time that they open the Account Security page, then users must be given a meaningful choice (i.e., it should be possible to dismiss the warning by clicking No.

Operating System

Windows

Operating System Version

11

Web Browser

Chrome

Browser Version

No response

Build Version

2024.6.2

Issue Tracking Info

• [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

[trmartin4]

Hello! This has been identified internally and is currently fixed in our main branch (https://github.com/bitwarden/clients/pull/9579). It will be included in our next release.