bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

[PM-9207] Fix desktop builds by installing Python setuptools #9839

Closed dani-garcia closed 3 days ago

dani-garcia commented 3 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9207

📔 Objective

The updates to the argon2 package seem to have broken the MacOS desktop builds, as they are missing the Python package setuptools.

To fix the builds, I've added the package to build-desktop.yml, just like it already is in release-desktop-beta.yml

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 3 days ago

Logo Checkmarx One – Scan Summary & Detailse1ee58a5-e479-4774-b2c7-19d44ea5c7e9

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1265 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1219 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1210
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1256