[PM-9250] Move send icons to @bitwarden/send-ui

djsmith85 commented 3 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9250

📔 Objective

Preparing to re-use the existing icons on other clients (namely browser for the extension UI refresh)

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.33%. Comparing base (8df054c) to head (028c37e). Report is 2 commits behind head on main.

Files	Patch %	Lines
apps/web/src/app/tools/send/access.component.ts	0.00%	2 Missing :warning:
apps/web/src/app/tools/send/send.component.ts	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9840 +/- ## ========================================== + Coverage 29.32% 29.33% +0.01% ========================================== Files 2528 2526 -2 Lines 73767 73764 -3 Branches 13771 13772 +1 ========================================== + Hits 21630 21637 +7 + Misses 50515 50505 -10 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Checkmarx One – Scan Summary & Details – 59a2c2f7-3e5b-4e47-8f8f-57b1429cd39f

bitwarden / clients