bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
8.65k stars 1.14k forks source link

[PM-9253] Create "new Send"-button with type selection #9842

Closed djsmith85 closed 2 days ago

djsmith85 commented 3 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9253

📔 Objective

Create a new button and dropdown from which a user can select which type of Send they want to create (text/file)

Once selected the user will be directed to the send-add-edit page.

No QA needed as this component is not used anywhere yet. It will be tested once the SendV2 and SendAddEditV2 components have been built.

📸 Screenshots

image

⏰ Reminders before review

🦮 Reviewer guidelines

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.33%. Comparing base (1495b06) to head (3940bbf).

:exclamation: Current head 3940bbf differs from pull request most recent head d317044

Please upload reports for the commit d317044 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9842 +/- ## ======================================= Coverage 29.32% 29.33% ======================================= Files 2527 2528 +1 Lines 73783 73768 -15 Branches 13778 13772 -6 ======================================= Hits 21637 21637 + Misses 50524 50509 -15 Partials 1622 1622 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Logo Checkmarx One – Scan Summary & Details05584b36-09c0-4c1d-8cae-78bcf23d5b56

No New Or Fixed Issues Found