Open cagonzalezcs opened 2 days ago
Attention: Patch coverage is 89.74359%
with 128 lines
in your changes missing coverage. Please review.
Project coverage is 30.91%. Comparing base (
e560711
) to head (33e1226
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One โ Scan Summary & Details โ 6629b44b-9be8-4b4b-a6cc-8c594f225900
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Client_Use_Of_Iframe_Without_Sandbox | /apps/browser/src/autofill/deprecated/overlay/iframe-content/autofill-overlay-iframe.service.deprecated.ts: 90 | Attack Vector |
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/PM-9267
๐ Objective
This PR is being made with consideration to the scope of behavioral changes within https://github.com/bitwarden/clients/pull/8431
We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.
This work for this ticket sets up a feature flag to enable the re-architected overlay, pulling the deprecated implementation into a separate folder that will be removed once we are confident in the updated inline menu implementation.
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or โ ๏ธ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes