[PM-9306] shuffle copied array

audreyality commented 2 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9306

📔 Objective

Shuffle the copy of the array so that the input argument isn't modified unless requested by the caller.

Note: QA to be performed on rc.

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (89a34a3) to head (ac32088).

Files	Patch %	Lines
libs/common/src/tools/generator/random.ts	0.00%	2 Missing :warning:
...rator/core/src/engine/crypto-service-randomizer.ts	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9847 +/- ## ========================================== - Coverage 29.32% 29.31% -0.01% ========================================== Files 2527 2527 Lines 73806 73806 Branches 13781 13781 ========================================== - Hits 21641 21634 -7 - Misses 50540 50547 +7 Partials 1625 1625 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 days ago

Checkmarx One – Scan Summary & Details – b1c6edf6-7103-4f84-8aab-aae0bbb2005f

bitwarden / clients