[PM-2857] Inline menu credit card autofill

cagonzalezcs commented 6 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-2857

📔 Objective

The goal of this ticket is to incorporate credit card autofill into the inline menu, and to ensure parity with the login autofill behavior that currently exists. This also includes conditionally setting the presentation of credit card ciphers within form fields that are specifically related to credit card forms.

📸 Demo

https://github.com/bitwarden/clients/assets/16629865/a11ae912-77fa-4e3a-97e2-332cf3f4f5f8

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 92.54902% with 19 lines in your changes missing coverage. Please review.

Project coverage is 31.10%. Comparing base (c444622) to head (1c9ff12).

Files	Patch %	Lines
...wser/src/autofill/background/overlay.background.ts	86.79%	0 Missing and 7 partials :warning:
...nline-menu/pages/list/autofill-inline-menu-list.ts	85.36%	6 Missing :warning:
...ofill/services/autofill-overlay-content.service.ts	91.17%	0 Missing and 6 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## autofill/pm-8207-cannot-use-keyboard-with-scribe-extension #9848 +/- ## ============================================================================================== + Coverage 30.96% 31.10% +0.14% ============================================================================================== Files 2554 2554 Lines 75888 76081 +193 Branches 14221 14292 +71 ============================================================================================== + Hits 23497 23668 +171 - Misses 50653 50663 +10 - Partials 1738 1750 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 days ago

Checkmarx One – Scan Summary & Details – 77afbed4-bfca-4736-9f40-16f9b485f7ee

bitwarden / clients