Remove the `bit` prefix from Bitwarden License managed build artifacts

addisonbeck commented 6 days ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2812

📔 Objective

We've decided to cut the bit prefix from the new CLI artifacts so that instead of publishing bw-bit-{OS}.zip and bw-oss-{OS}.zip we just publish bw-{OS}.zip and bw-oss-{OS}.zip.

This PR achieves this by updating the build job only add an artifact prefix to the OSS build, and adjusting the release job to download the correct artifacts.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.46%. Comparing base (5ce4e8f) to head (ce86636). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9855 +/- ## ======================================= Coverage 29.46% 29.46% ======================================= Files 2533 2532 -1 Lines 74029 74022 -7 Branches 13825 13825 ======================================= - Hits 21816 21814 -2 + Misses 50561 50556 -5 Partials 1652 1652 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 days ago

Checkmarx One – Scan Summary & Details – e4549610-d300-4600-9260-7607cee0e437

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 402	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 406

bitwarden / clients